-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade EUI to v44.0.0 #122386
Upgrade EUI to v44.0.0 #122386
Conversation
Pinging @elastic/eui-design (EUI) |
cc @nickofthyme |
I'll look into the security failures tomorrow. @thompsongl heads up that the |
@elasticmachine merge upstream |
Pinging @elastic/uptime (Team:uptime) |
@elastic/security-solution, @elastic/workplace-search-frontend - would y'all mind reviewing the appropriate source changes in your respective touched files? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I noticed a rendering issue on the alert table within the security solution: There is extra white-space below the last element in the table. This is caused by the "height-hack" that was introduced in #109269. Removing that height-hack fixes the issue. I don't think the removal needs to be part of this PR though, I will make sure to remove that hack in a follow-up PR. |
Thanks @janmonschke! Just to clarify, did you notice this on latest main or specifically on this branch? If on latest main, that was a fix that likely was in the previous EUI upgrade, and you should be able to open a PR whenever. Super appreciate y'all taking care of it either way! |
@constancecchen I first noticed it on the latest main and then saw this PR that has another fix for the data grid which fixes all the issues we were trying to solve with the height hack. Will create a PR after this one made it into main :) |
@elasticmachine merge upstream |
@elastic/security-solution - heads up I'll be merging this with or without approval in a few hours. Changes were relatively straightforward, but would appreciate your eyes on this if you have time (or after merge, however timing shakes out). |
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
💔 Backport failedThe pull request could not be backported due to the following error: How to fixRe-run the backport manually:
Questions ?Please refer to the Backport tool documentation |
Summary
[email protected]
⏩[email protected]
44.0.0
Bug fixes
EuiDataGrid
sizing bug which didn't account for a horizontal scrollbar (#5478)EuiDatePicker
a11y bug where axe-core reported missing ARIA and role attributes (#5501)EuiModalHeaderTitle
to conditionally wrap title strings in an H1 (#5494)EuiDataGrid
issue where a focused cell would lose focus when scrolled out of and back into view (#5488)EuiDatePicker
accessibility issue wheretabindex
was not applied to a listbox element (#5509)Deprecations
PartitionConfig
in favor of inclusion in Chartstheme.partition
(#5492)Breaking changes
popoverClassName
andrepositionOnScroll
props fromEuiSuperSelect
(usepopoverProps
instead) (#5512)