[Fleet] Handle error correctly in fleet server host input on prem instructions #122341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
v8.0.0
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
nchaulet
changed the title
kpollich
approved these changes
Jan 5, 2022
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @nchaulet |
💔 Backport failed
Successful backport PRs will be merged automatically after passing CI. To backport manually run: |
kibanamachine
added a commit
that referenced
this pull request
Jan 5, 2022
…tructions (#122341) (#122351) Co-authored-by: Nicolas Chaulet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve #122228
In the fleet server on prem instructions we were not handling errors correctly that PR fix that.
UI Changes and how to test
Try to add an http fleet server host than an https fleet server hosts you should see an error.