Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add KibanaThemeProvider support for kibana-app-services #122340

Conversation

shivindera
Copy link
Contributor

Part of #118866

Adds the theme provider to all react roots maintained by the kibana-app-services team

@shivindera shivindera requested review from a team as code owners January 5, 2022 14:33
@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Jan 5, 2022
@shivindera shivindera added v8.1.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:AppServicesSv labels Jan 5, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@shivindera shivindera removed the Feature:Embedding Embedding content via iFrame label Jan 5, 2022
@kibana-ci
Copy link
Collaborator

kibana-ci commented Jan 5, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #7 / ErrorEmbeddable renders an embeddable
  • [job] [logs] Jest Tests #7 / ErrorEmbeddable renders an embeddable with markdown message
  • [job] [logs] Jest Tests #5 / useSavedVisInstance create new visualization route should throw error if index pattern or saved search id doesn't exist in search params
  • [job] [logs] Jest Tests #5 / useSavedVisInstance create new visualization route should throw error if vis type is invalid

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
embeddable 374 377 +3
kibanaUtils 418 419 +1
uiActions 90 93 +3
total +7
Unknown metric groups

API count

id before after diff
embeddable 452 455 +3
kibanaUtils 613 614 +1
uiActions 129 132 +3
total +7

ESLint disabled in files

id before after diff
apm 15 14 -1
osquery 5 4 -1
securitySolution 67 66 -1
uptime 5 4 -1
total -4

ESLint disabled line counts

id before after diff
apm 87 84 -3
enterpriseSearch 7 6 -1
osquery 114 111 -3
uptime 38 36 -2
total -9

References to deprecated APIs

id before after diff
canvas 70 64 -6
dashboard 254 243 -11
data 477 467 -10
dataEnhanced 49 43 -6
dataViewFieldEditor 31 20 -11
dataViewManagement 498 434 -64
dataVisualizer 237 227 -10
discover 1835 1520 -315
fleet 39 35 -4
inputControlVis 325 295 -30
lens 269 207 -62
management 2 1 -1
maps 1402 906 -496
monitoring 53 41 -12
screenshotting 12 8 -4
security 31 23 -8
stackAlerts 183 157 -26
upgradeAssistant 12 7 -5
visDefaultEditor 213 163 -50
visTypeTimeseries 331 316 -15
visTypeVega 25 24 -1
visualizations 86 76 -10
visualize 41 37 -4
total -1161

Total ESLint disabled count

id before after diff
apm 102 98 -4
enterpriseSearch 7 6 -1
osquery 119 115 -4
securitySolution 522 521 -1
uptime 43 40 -3
total -13

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shivindera shivindera marked this pull request as draft January 5, 2022 15:00
@shivindera shivindera closed this Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants