Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datatable][Inspector] Make inspectable/exportable only visible columns #122268

Closed
wants to merge 4 commits into from

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Jan 4, 2022

Summary

Fix #121947

This PR leverages the dimensionName meta information in each column of the datatable.

The work here would also be useful for Lens as a better version of #121802 as soon as the dimension information will be included in the datatable (see #118516) .

Screenshot 2022-01-04 at 17 05 48

Screenshot 2022-01-04 at 17 05 56

Checklist

Delete any items that are not applicable to this PR.

@dej611 dej611 added Feature:Data Table Data table visualization feature release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Inspector Inspector infrastructure and implementations labels Jan 4, 2022
@dej611 dej611 changed the title [Datatable] Make inspectable/exportable only visible columns [Datatable][Inspector] Make inspectable/exportable only visible columns Jan 4, 2022
@dej611
Copy link
Contributor Author

dej611 commented Jan 10, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jan 10, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] OSS CI Group #7 / visualize app new charts library visualize ciGroup7 line charts - split series should show correct data, ordered by Term
  • [job] [logs] OSS CI Group #7 / visualize app new charts library visualize ciGroup7 line charts - split series should show correct data, ordered by Term
  • [job] [logs] Default CI Group #4 / Visualize hybrid index pattern should render histogram line chart
  • [job] [logs] Default CI Group #4 / Visualize hybrid index pattern should render histogram line chart

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
data 517 518 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
data 108.3KB 108.3KB +21.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 445.0KB 445.2KB +225.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
data 44 46 +2

Total ESLint disabled count

id before after diff
data 48 50 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 closed this Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Data Table Data table visualization feature Feature:Inspector Inspector infrastructure and implementations release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Datatable] When I enable the partial rows, the inspector shows metrics for each bucket
3 participants