Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Functional tests - stabilize anomaly explorer tests #122247

Merged
merged 3 commits into from
Jan 5, 2022
Merged

[ML] Functional tests - stabilize anomaly explorer tests #122247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3db4ba2
[ML] Functional tests - stabilize anomaly explorer tests
pheyos Jan 4, 2022
5a84dbe
Remove debug skips
pheyos Jan 4, 2022
8aa9e3d
Fix typo
pheyos Jan 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...k/plugins/ml/public/application/explorer/dashboard_controls/add_to_dashboard_controls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,9 @@ export const AddToDashboardControl: FC<AddToDashboardControlProps> = ({
pagination={true}
sorting={true}
data-test-subj={`mlDashboardSelectionTable${isLoading ? ' loading' : ' loaded'}`}
rowProps={(item) => ({
'data-test-subj': `mlDashboardSelectionTableRow row-${item.id}`,
})}
/>
</EuiFormRow>
</EuiModalBody>
Expand Down
3 changes: 1 addition & 2 deletions x-pack/test/functional/apps/ml/anomaly_detection/anomaly_explorer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,7 @@ export default function ({ getService }: FtrProviderContext) {
const ml = getService('ml');
const elasticChart = getService('elasticChart');

// FLAKY: https://github.com/elastic/kibana/issues/118584
describe.skip('anomaly explorer', function () {
describe('anomaly explorer', function () {
this.tags(['mlqa']);
before(async () => {
await esArchiver.loadIfNeeded('x-pack/test/functional/es_archives/ml/farequote');
Expand Down
22 changes: 15 additions & 7 deletions x-pack/test/functional/services/ml/anomaly_explorer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,13 +121,21 @@ export function MachineLearningAnomalyExplorerProvider({
});
},

async filterDashboardSearchWithSearchString(filter: string) {
await this.waitForDashboardsToLoad();
const searchBarInput = await testSubjects.find('mlDashboardsSearchBox');
await searchBarInput.clearValueWithKeyboard();
await searchBarInput.type(filter);
await this.assertDashboardSearchInputValue(filter);
await this.waitForDashboardsToLoad();
async filterDashboardSearchWithSearchString(filter: string, expectedRowCount: number = 1) {
await retry.tryForTime(20 * 1000, async () => {
await this.waitForDashboardsToLoad();
const searchBarInput = await testSubjects.find('mlDashboardsSearchBox');
await searchBarInput.clearValueWithKeyboard();
await searchBarInput.type(filter);
await this.assertDashboardSearchInputValue(filter);
await this.waitForDashboardsToLoad();

const dashboardRows = await testSubjects.findAll('~mlDashboardSelectionTableRow', 2000);
expect(dashboardRows.length).to.eql(
expectedRowCount,
`Dashboard table should have ${expectedRowCount} rows, got ${dashboardRows.length}`
);
});
},

async assertDashboardSearchInputValue(expectedSearchValue: string) {
Expand Down