Added Component Integration Test For Force Merging an Index #122176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ar index cache test because there were overlapping act calls.
cuff-links
added
Feature:Index Management
|
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
sabarasaba
approved these changes
Dec 31, 2021
There was a problem hiding this comment.
Thanks for adding this test @cuff-links! Changes lgtm, left 2 small things we should change before merging regarding a few comments 🚀
x-pack/plugins/index_management/__jest__/client_integration/home/indices_tab.test.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/index_management/__jest__/client_integration/home/indices_tab.test.ts
Outdated
Show resolved
Hide resolved
…me/indices_tab.test.ts Co-authored-by: Ignacio Rivas <[email protected]>
…me/indices_tab.test.ts Co-authored-by: Ignacio Rivas <[email protected]>
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @sabarasaba |
💔 Backport failed
To backport manually run: |
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
removed
the
backport missing
cuff-links
pushed a commit
to cuff-links/kibana
that referenced
this pull request
Jan 4, 2022
…122176) * Added new test for force merge action. Also added an await in the clear index cache test because there were overlapping act calls. * Removed calls from previous copied test. * Update x-pack/plugins/index_management/__jest__/client_integration/home/indices_tab.test.ts Co-authored-by: Ignacio Rivas <[email protected]> * Update x-pack/plugins/index_management/__jest__/client_integration/home/indices_tab.test.ts Co-authored-by: Ignacio Rivas <[email protected]> Co-authored-by: Ignacio Rivas <[email protected]> Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/plugins/index_management/__jest__/client_integration/home/indices_tab.helpers.ts
cuff-links
pushed a commit
that referenced
this pull request
Jan 5, 2022
…122176) (#122299) * Added Component Integration Test For Force Merging an Index (#122176) * Added new test for force merge action. Also added an await in the clear index cache test because there were overlapping act calls. * Removed calls from previous copied test. * Update x-pack/plugins/index_management/__jest__/client_integration/home/indices_tab.test.ts Co-authored-by: Ignacio Rivas <[email protected]> * Update x-pack/plugins/index_management/__jest__/client_integration/home/indices_tab.test.ts Co-authored-by: Ignacio Rivas <[email protected]> Co-authored-by: Ignacio Rivas <[email protected]> Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/plugins/index_management/__jest__/client_integration/home/indices_tab.helpers.ts * Update indices_tab.helpers.ts Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a component integration test that checks that we are able to click the force merge button for an index, click the force merge button on the confirmation dialogue and check the last request to ensure that it was made to the force merge API.