Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics UI] Stabilize group header functional test #122169

Merged
merged 2 commits into from
Jan 4, 2022
Merged

[Metrics UI] Stabilize group header functional test #122169

merged 2 commits into from
Jan 4, 2022

Conversation

weltenwort
Copy link
Member

📝 Summary

Wrap group header check into retry

closes #119701
closes #120760

@weltenwort weltenwort added Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 v7.17.0 v7.16.2 labels Dec 30, 2021
@weltenwort weltenwort self-assigned this Dec 30, 2021
@weltenwort weltenwort marked this pull request as ready for review December 30, 2021 17:15
@weltenwort weltenwort requested a review from a team as a code owner December 30, 2021 17:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@weltenwort weltenwort added the release_note:skip Skip the PR/issue when compiling release notes label Dec 30, 2021
miltonhultgren
miltonhultgren approved these changes Dec 31, 2021
View reviewed changes
Copy link
Contributor

@miltonhultgren miltonhultgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@weltenwort
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @weltenwort

@weltenwort weltenwort merged commit 535c058 into elastic:main Jan 4, 2022
@weltenwort weltenwort deleted the metrics-ui-functional-test-retry-inventory-group branch January 4, 2022 17:19
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jan 4, 2022
@weltenwort @kibanamachine
[Metrics UI] Stabilize group header functional test (elastic#122169)
da8a502 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Jan 4, 2022
Merged
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
✅ 8.0
❌ 7.17 Commit could not be cherrypicked due to conflicts
❌ 7.16 Commit could not be cherrypicked due to conflicts

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 122169

@weltenwort
Copy link
Member Author

Looks like the group header test was not backported beyond 8.0, so I won't be able to backport this to 7.16 and 7.17 either.

kibanamachine added a commit that referenced this pull request Jan 4, 2022
@kibanamachine @weltenwort
[Metrics UI] Stabilize group header functional test (#122169) (#122279)
2dc83cd 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Felix Stürmer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miltonhultgren miltonhultgren miltonhultgren approved these changes

Assignees

@weltenwort weltenwort

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
5 participants
@weltenwort @elasticmachine @kibana-ci @kibanamachine @miltonhultgren