[Console] Encode pathname #122080
Merged
[Console] Encode pathname #122080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mibragimov
force-pushed
the
encoding-pathname
branch
2 times, most recently
from
f0e845d to
d7cdb31
Compare
mibragimov
added
backport:skip
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
|
@elasticmachine merge upstream |
mibragimov
requested review from
sabarasaba
and removed request for
Kuznietsov
Kuznietsov
approved these changes
Jan 24, 2022
sabarasaba
approved these changes
Jan 24, 2022
There was a problem hiding this comment.
Thanks for patching this up @mibragimov! changes lgtm, tested locally 🚀
I think would be nice to enhance the current tests in order to include this new behaviour :)
| @@ -44,6 +58,7 @@ export const proxyRequest = ({ | |||
| }: Args) => { | |||
| const { hostname, port, protocol, pathname, search } = uri; | |||
| const client = uri.protocol === 'https:' ? https : http; | |||
| const encodedPath = encodePathname(pathname); | |||
There was a problem hiding this comment.
could we add some tests to cover this new behaviour in https://github.com/elastic/kibana/blob/main/src/plugins/console/server/lib/proxy_request.test.ts ?
mibragimov
force-pushed
the
encoding-pathname
branch
from
e80bac8 to
460ffb9
Compare
Kuznietsov
approved these changes
Jan 27, 2022
alexwizp
approved these changes
Jan 27, 2022
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @mibragimov |
awahab07
pushed a commit
to awahab07/kibana
that referenced
this pull request
Jan 31, 2022
* Fix encoding pathname * Add a test case Co-authored-by: Muhammad Ibragimov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #76585