Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Prevent event propagation on step_duration #122039

Merged
merged 1 commit into from
Dec 28, 2021
Merged

[Uptime] Prevent event propagation on step_duration #122039

merged 1 commit into from
Dec 28, 2021

Conversation

emilioalvap
Copy link
Contributor

@emilioalvap emilioalvap commented Dec 27, 2021 •
edited
Loading

Summary

Fixes #122032.

Prevent click event propagation when interacting with step_duration popover.

Checklist

@emilioalvap emilioalvap added v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 labels Dec 27, 2021
@emilioalvap emilioalvap requested a review from a team as a code owner December 27, 2021 17:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 681.7KB 681.8KB +31.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@awahab07 awahab07 added the bug Fixes for quality problems that affect the customer experience label Dec 27, 2021
awahab07
awahab07 approved these changes Dec 28, 2021
View reviewed changes
Copy link
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Before and after video:
https://user-images.githubusercontent.com/2748376/147520544-483450d2-265a-4a1b-8641-06496b69e4a9.mov

@emilioalvap emilioalvap merged commit 4c07aba into elastic:main Dec 28, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 28, 2021
@emilioalvap @kibanamachine
Prevent event propagation on step_duration (elastic#122039)
0041fab
@kibanamachine kibanamachine mentioned this pull request Dec 28, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Dec 28, 2021
@kibanamachine @emilioalvap
Prevent event propagation on step_duration (#122039) (#122065)
c6f8b2f 
Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awahab07 awahab07 awahab07 approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:fix Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Step Lists Page] Prevent duration popover event propagation
5 participants
@emilioalvap @elasticmachine @kibana-ci @kibanamachine @awahab07