[Reporting] Promote selected tests as integration tests #121903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
release_note:skip
dokmic
approved these changes
Dec 27, 2021
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Dec 27, 2021
* move test files to integration_tests * cleanup * fix2 * [Reporting] Fix skipped integrations test # Conflicts: # x-pack/plugins/reporting/server/routes/diagnostic/integration_tests/browser.test.ts # x-pack/plugins/reporting/server/routes/generate/integration_tests/generation_from_jobparams.test.ts # x-pack/plugins/reporting/server/routes/management/integration_tests/jobs.test.ts
tsullivan
added a commit
that referenced
this pull request
Dec 27, 2021
…22040) * move test files to integration_tests * cleanup * fix2 * [Reporting] Fix skipped integrations test # Conflicts: # x-pack/plugins/reporting/server/routes/diagnostic/integration_tests/browser.test.ts # x-pack/plugins/reporting/server/routes/generate/integration_tests/generation_from_jobparams.test.ts # x-pack/plugins/reporting/server/routes/management/integration_tests/jobs.test.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to make Reporting long-running tests more stable. Certain tests integrate with other dependencies and need to be classified as "integration tests" by making them in a folder named
integration_tests.Closes #87021
Closes #115881