Expose Saved Object API to Server #12182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nreese would you mind updating the routes above this change to use the new method? Updating the pre function to use the new method on request would prevent multiple implementations from existing in the same file, would reuse the cache, and would keep the changed lines pretty low. But if you're up for changing the routes to use the new method too I wouldn't complain 😄 |
spalger
reviewed
Jun 6, 2017
| const { callWithRequest } = server.plugins.elasticsearch.getCluster('admin'); | ||
| const callAdminCluster = (...args) => callWithRequest(request, ...args); | ||
| const savedObjectsClient = new SavedObjectsClient( | ||
| server.config().get('kibana.index'), |
There was a problem hiding this comment.
indentation here should be two spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR decorates request objects with a method
getSavedObjectsClientthat provides convenient access to the Saved Object API.