Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds test case for use_get_user_cases_permissions module #121808

Merged
merged 4 commits into from
Dec 28, 2021
Merged

Adds test case for use_get_user_cases_permissions module #121808

merged 4 commits into from
Dec 28, 2021

Conversation

claudiopro
Copy link
Contributor

@claudiopro claudiopro commented Dec 21, 2021 •
edited
Loading

Summary

This PR adds a new test case for the useGetUserCasesPermissions hook. No functional changes, bar a minor optional chaining operator ?. for a maybe null field.

Checklist

@claudiopro claudiopro added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed Theme: rac label obsolete v8.1.0 Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" labels Dec 21, 2021
@claudiopro claudiopro requested a review from a team December 21, 2021 17:19
@claudiopro claudiopro requested a review from a team December 22, 2021 21:01
@claudiopro
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 351.9KB 352.0KB +74.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@claudiopro claudiopro merged commit 3a14135 into elastic:main Dec 28, 2021
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 28, 2021
@claudiopro claudiopro deleted the chore_test_use_get_user_cases_permissions branch December 28, 2021 11:05
@kibanamachine
Copy link
Contributor

💔 Backport failed

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 121808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estermv estermv estermv approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Theme: rac label obsolete v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@claudiopro @kibana-ci @kibanamachine @estermv