Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PieVis] Charts expressions pie adaptation. #121763

Merged
merged 52 commits into from
Jan 6, 2022
Merged

[PieVis] Charts expressions pie adaptation. #121763

merged 52 commits into from
Jan 6, 2022

Conversation

Kuznietsov
Copy link
Contributor

@Kuznietsov Kuznietsov commented Dec 21, 2021 •
edited
Loading

Summary

Completes the part of #121725 and #101377

Introduced changes:

Screenshot 2021-12-22 at 17 53 51

Kuznietsov and others added 22 commits December 17, 2021 18:11
@Kuznietsov
Moved pie_vis to the other.
d13df0b
@Kuznietsov
Added semicolon.
32a2a81
@Kuznietsov
Fixed check errors.
c5c41a6
@Kuznietsov
Removed not used types.
4c40252
@Kuznietsov
Changed docs.
6ef8429
@Kuznietsov
Fixed labels.
282c017
@Kuznietsov
Fixed more translation labels.
b01e118
@Kuznietsov
Merge branch 'main' into charts_expressions-pie
3231f72 
# Conflicts:
#	src/plugins/chart_expressions/expression_pie/common/expression_functions/pie_vis_function.test.ts
@Kuznietsov
Removed own types and replaced by expression_pie.
e54c816
@Kuznietsov
Changed types of buildExpressionFunction.
a363fb3
@Kuznietsov
Added limits and extraPublicDir.
7faa2b6
@Kuznietsov
Fixed i18n checks.
604f497
@Kuznietsov
Fixes.
1f9d54c
@Kuznietsov
More fixes.
90dd2ee
@Kuznietsov
Fixed translations checks.
c300657
@Kuznietsov
More translation fixes.
457e4f8
@Kuznietsov
Added displayName and help for renderer.
17d6c65
@Kuznietsov
Removed as statement.
679e11c
@kibanamachine
Merge branch 'main' into charts_expressions-pie
2160608
@Kuznietsov
Replaced data.fieldFormats with fieldFormats.
e83b93d
@Kuznietsov
Added support of visdimension.
37aacf8
@Kuznietsov
Fixed types of ExpressionValueVisDimension.
2e8cf1b
@Kuznietsov Kuznietsov self-assigned this Dec 21, 2021
@Kuznietsov Kuznietsov added accessibility: design system Accessibility issues that can be updated with EUI WIP Work in progress and removed accessibility: design system Accessibility issues that can be updated with EUI labels Dec 21, 2021
@Kuznietsov
Addressed comments about unused deps.
0d63551
@Kuznietsov
Fixed not used imports/refs.
16cbd77
@Kuznietsov
Merge branch 'charts_expressions-pie' into charts_expressions-pie-ada…
bc49b3e 
…ptation

# Conflicts:
#	src/plugins/chart_expressions/expression_pie/kibana.json
#	src/plugins/chart_expressions/expression_pie/public/types.ts
@Kuznietsov
Disabled legendColorPicker in case of uiState is not provided.
1b71942
@Kuznietsov
Merge branch 'main' into charts_expressions-pie-adaptation
46ff409 
# Conflicts:
#	src/plugins/chart_expressions/expression_pie/common/expression_functions/pie_vis_function.test.ts
#	src/plugins/chart_expressions/expression_pie/common/expression_functions/pie_vis_function.ts
#	src/plugins/chart_expressions/expression_pie/common/types/expression_functions.ts
#	src/plugins/chart_expressions/expression_pie/common/types/expression_renderers.ts
#	src/plugins/chart_expressions/expression_pie/kibana.json
#	src/plugins/chart_expressions/expression_pie/public/components/pie_vis_component.scss
#	src/plugins/chart_expressions/expression_pie/public/components/pie_vis_component.test.tsx
#	src/plugins/chart_expressions/expression_pie/public/components/pie_vis_component.tsx
#	src/plugins/chart_expressions/expression_pie/public/expression_renderers/pie_vis_renderer.tsx
#	src/plugins/chart_expressions/expression_pie/public/plugin.ts
#	src/plugins/chart_expressions/expression_pie/public/types.ts
#	src/plugins/chart_expressions/expression_pie/public/utils/get_split_dimension_accessor.ts
#	src/plugins/chart_expressions/expression_pie/tsconfig.json
#	src/plugins/vis_types/pie/public/to_ast.ts
#	src/plugins/vis_types/pie/public/types/types.ts
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
expressionPie 42 37 -5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionPie 43.3KB 39.4KB -3.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressionPie 11.0KB 11.3KB +268.0B
visTypePie 7.8KB 7.9KB +104.0B
total +372.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
expressionPie 1 3 +2

References to deprecated APIs

id before after diff
expressionPie 15 6 -9

Total ESLint disabled count

id before after diff
expressionPie 1 3 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

@Kuznietsov Kuznietsov marked this pull request as ready for review January 5, 2022 08:39
@Kuznietsov Kuznietsov requested review from a team as code owners January 5, 2022 08:39
@Kuznietsov Kuznietsov added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jan 5, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@Kuznietsov Kuznietsov added Feature:Vis Editor Visualization editor issues loe:medium Medium Level of Effort Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.1.0 and removed Feature:Visualizations Generic visualization features (in case no more specific feature label is available) WIP Work in progress labels Jan 5, 2022
@Kuznietsov Kuznietsov mentioned this pull request Jan 5, 2022
Closed
7 tasks
stratoula
stratoula approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. I tested it locally in Chrome and works fine (the viz editor pie, I haven't tested the canvas pie) :) Thanx for the improvements Yaroslav :)

@Kuznietsov
Copy link
Contributor Author

@elastic/kibana-operations and @elastic/kibana-design, could you, please, review the current PR? Thanks)

@Kuznietsov Kuznietsov merged commit 3e91803 into elastic:main Jan 6, 2022
@Kuznietsov
Copy link
Contributor Author

@jbudz and @MichaelMarcialis, thanks for your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

@MichaelMarcialis MichaelMarcialis MichaelMarcialis approved these changes

@stratoula stratoula stratoula approved these changes

@crob611 crob611 Awaiting requested review from crob611

@flash1293 flash1293 Awaiting requested review from flash1293

@alexwizp alexwizp Awaiting requested review from alexwizp

Assignees

@Kuznietsov Kuznietsov

Labels
backport:skip This commit does not require backporting Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Feature:Vis Editor Visualization editor issues impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Kuznietsov @kibana-ci @elasticmachine @jbudz @MichaelMarcialis @stratoula @kibanamachine