Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NA): @kbn/securitysolution-io-ts-list-types to build on windows #121753

Conversation

mistic
Copy link
Member

@mistic mistic commented Dec 21, 2021

This PR fixes the build on Windows after the merge of #121683 where we forgot to add a dependency.

@mistic mistic added chore Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Dec 21, 2021
@mistic mistic requested a review from peteharverson December 21, 2021 12:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic
Copy link
Member Author

mistic commented Dec 21, 2021

@elasticmachine merge upstream

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and LGTM

@mistic mistic enabled auto-merge (squash) December 21, 2021 13:17
@mistic
Copy link
Member Author

mistic commented Dec 21, 2021

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit a04f86d into elastic:main Dec 21, 2021
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants