[Stack Monitoring] update monitoring index patterns to be non-versioned

[matschaffer]

Summary

Rel #121251

This updates stack monitoring index patterns to look for any monitoring prefix.

This supports our current 6 & 7, as well as 8 which is getting ready for release and covers our metricbeat index patterns.

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
• If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/infra-monitoring-ui (Team:Monitoring)

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 458194a
• Storybooks Preview

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
monitoring	23.7KB	23.6KB	-97.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @matschaffer

[matschaffer]

Kind of surprised that passed. What say you @klacabane , merge it?

[claudiopro]

Looks legit from a pattern matching perspective. Curious to hear @klacabane's feedback.

[claudiopro]

Note: isn't this pattern also encompassing the other four?

[klacabane]

I wonder what was the reasoning behind the hardcoded versions here ? Could we have some legacy .monitoring version 5 out there that we don't support anymore ?

[matschaffer]

fair thing to wonder. Maybe @jasonrhodes or @chrisronline have some idea?

[matschaffer]

I spun up a 5.6.16 cluster to test and the monitoring indices are -6 interestingly enough.

I guess I could just add another comma and add 8 if we want to play it safe. But if the 5.x stack is also 6 and the last 5 release was EOL 2019-03-11, it might be reasonable to remove the version now.

[klacabane]

I wonder what was the reasoning behind the hardcoded versions here ? Could we have some legacy .monitoring version 5 out there that we don't support anymore ?

[matschaffer]

Closing in favor of #121641