[XY] Fixes the broken chart when an agg is placed in another axis and then is hidden #121488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
changed the title
stratoula
added
Feature:XYAxis
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
|
There's still some issue with the right axis - it doesn't show any ticks or axis label: if i'm enabling both it starts working |
|
Thanx @flash1293 for pointing this out. I changed the implementation of computing the axis and I think that now all cases work fine. |
flash1293
approved these changes
Dec 17, 2021
| @@ -38,7 +38,31 @@ describe('getConfig', () => { | |||
| it('assigns the correct formatter per y axis', () => { | |||
| const config = getConfig(visData, visParamsWithTwoYAxes); | |||
| expect(config.yAxes.length).toBe(2); | |||
| expect(config.yAxes[0].ticks?.formatter).toStrictEqual(config.aspects.y[1].formatter); | |||
| expect(config.yAxes[1].ticks?.formatter).toStrictEqual(config.aspects.y[0].formatter); | |||
| expect(config.yAxes[0].ticks?.formatter).toStrictEqual(config.aspects.y[0].formatter); | |||
There was a problem hiding this comment.
Can you explain this change? It seems like now another formatter is attached per axis but I can't see why that should happen.
There was a problem hiding this comment.
I changed the implementation of calculating the yAxes array. So in the old way (we were looping into the valueAxes array to compute it), the y Axes was : ["left-axis", "right-axis"]
With the current implementation (looping the dimensions.y) the yAxes looks like ["right-axis", "left-axis"].
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 17, 2021
… then is hidden (elastic#121488) * [XY] Fixes the broken chart when an agg is placed in another axis and then is hidden * Fix yAxes ticks * Fix test borkem due to the change of the implementation
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 17, 2021
… then is hidden (elastic#121488) * [XY] Fixes the broken chart when an agg is placed in another axis and then is hidden * Fix yAxes ticks * Fix test borkem due to the change of the implementation
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 17, 2021
… then is hidden (elastic#121488) * [XY] Fixes the broken chart when an agg is placed in another axis and then is hidden * Fix yAxes ticks * Fix test borkem due to the change of the implementation
kibanamachine
added a commit
that referenced
this pull request
Dec 17, 2021
… then is hidden (#121488) (#121554) * [XY] Fixes the broken chart when an agg is placed in another axis and then is hidden * Fix yAxes ticks * Fix test borkem due to the change of the implementation Co-authored-by: Stratoula Kalafateli <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 17, 2021
… then is hidden (#121488) (#121555) * [XY] Fixes the broken chart when an agg is placed in another axis and then is hidden * Fix yAxes ticks * Fix test borkem due to the change of the implementation Co-authored-by: Stratoula Kalafateli <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 17, 2021
… then is hidden (#121488) (#121556) * [XY] Fixes the broken chart when an agg is placed in another axis and then is hidden * Fix yAxes ticks * Fix test borkem due to the change of the implementation Co-authored-by: Stratoula Kalafateli <[email protected]>
This was referenced Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #121268
There is a bug when you try to create a XY chart with two metrics on two y axes (one in the left and one in the right). If you hide one of the aggs, then the chart was failing with the error:
This PR fixes it:
Checklist