Fix flaky /api/status FTR test #121486
Merged
Fix flaky /api/status FTR test #121486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
Team:Core
pgayvallet
commented
Dec 17, 2021
| @@ -26,7 +25,7 @@ export default function ({ getService }) { | |||
| expect(body.version.build_number).to.be.a('number'); | |||
|
|
|||
| expect(body.status.overall).to.be.an('object'); | |||
| expect(body.status.overall.level).to.be('available'); | |||
| expect(body.status.overall.level).to.be.a('string'); | |||
There was a problem hiding this comment.
This test is here to ensure the shape of the data. Asserting against the actual status was causing flakiness if for any reason Kibana is not fully green when the test is run
pgayvallet
added
auto-backport
💛 Build succeeded, but was flaky
Test Failures
Metrics [docs]
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-core (Team:Core) |
mshustov
approved these changes
Dec 17, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 17, 2021
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Dec 17, 2021
Co-authored-by: Pierre Gayvallet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #116060