Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix Maps layer type name to new convention for File upload #121218

Merged
merged 1 commit into from
Dec 14, 2021
Merged

[ML] Fix Maps layer type name to new convention for File upload #121218

merged 1 commit into from
Dec 14, 2021

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Dec 14, 2021

Summary

This PR fixes the maps in the file upload table not showing correctly because the layer type is outdated (the types were named here)

Before
image

After
Screen Shot 2021-12-14 at 11 57 39

@qn895 qn895 added bug Fixes for quality problems that affect the customer experience :ml release_note:skip Skip the PR/issue when compiling release notes Feature:File and Index Data Viz ML file and index data visualizer v8.1.0 labels Dec 14, 2021
@qn895 qn895 self-assigned this Dec 14, 2021
@qn895 qn895 requested a review from a team as a code owner December 14, 2021 17:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 536.2KB 536.3KB +19.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

@qn895 qn895 merged commit bd58008 into elastic:main Dec 14, 2021
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 14, 2021
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@qn895 @TinLe
Fix layer type name to new convention (elastic#121218)
5e51ab4
@qn895 qn895 deleted the ml-dv-fix-file-upload-maps-not-showing branch December 27, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

Assignees

@qn895 qn895

Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience Feature:File and Index Data Viz ML file and index data visualizer :ml release_note:skip Skip the PR/issue when compiling release notes v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qn895 @elasticmachine @kibana-ci @peteharverson @kibanamachine