Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Wait for vis before asserting on it #121083

Merged
merged 1 commit into from
Dec 13, 2021
Merged

[Lens] Wait for vis before asserting on it #121083

merged 1 commit into from
Dec 13, 2021

Conversation

flash1293
Copy link
Contributor

Fixes #77969

In the screenshot you can see the filters are set correctly but the vis is not updated yet:
Screenshot 2021-12-13 at 14 53 29

This PR sets a waitForVisualization before asserting on the legend

@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 v7.16.1 labels Dec 13, 2021
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review December 13, 2021 15:16
@flash1293 flash1293 requested a review from a team as a code owner December 13, 2021 15:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

dej611
dej611 approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only 👍

Same solution has been applied already to similar issues.

@flash1293 flash1293 merged commit 43654e9 into elastic:main Dec 13, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 13, 2021
@flash1293 @kibanamachine
wait for vis before asserting on it (elastic#121083)
3b229ad
@kibanamachine kibanamachine mentioned this pull request Dec 13, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 13, 2021
@flash1293 @kibanamachine
wait for vis before asserting on it (elastic#121083)
0bde359
@kibanamachine kibanamachine mentioned this pull request Dec 13, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0
✅ 7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Dec 13, 2021
@kibanamachine @flash1293
wait for vis before asserting on it (#121083) (#121102)
db59580 
Co-authored-by: Joe Reuter <[email protected]>
kibanamachine added a commit that referenced this pull request Dec 13, 2021
@kibanamachine @flash1293
wait for vis before asserting on it (#121083) (#121103)
7c9c89a 
Co-authored-by: Joe Reuter <[email protected]>
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@flash1293 @TinLe
wait for vis before asserting on it (elastic#121083)
1a34232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dej611 dej611 dej611 approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.1 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
5 participants
@flash1293 @kibana-ci @elasticmachine @kibanamachine @dej611