Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v43.1.1 #120935

Merged
merged 47 commits into from
Dec 20, 2021
Merged
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
3d27dde
eui to v43.0.0
thompsongl Dec 9, 2021
ae5276c
update themeprovider types
thompsongl Dec 9, 2021
c233f80
Merge branch 'main' into eui/43.0
thompsongl Dec 9, 2021
9e49e8f
update sass import location
thompsongl Dec 9, 2021
d73dbee
storyshots
thompsongl Dec 9, 2021
138ab58
snapshots
thompsongl Dec 9, 2021
72de6ee
jest
thompsongl Dec 9, 2021
4ef571f
jest
thompsongl Dec 9, 2021
8c67812
Merge branch 'main' into eui/43.0
thompsongl Dec 9, 2021
0a4c8ed
timepicker functional test helpers
thompsongl Dec 9, 2021
1460999
snapshots
thompsongl Dec 9, 2021
655ab86
timepicker functional test helpers
thompsongl Dec 9, 2021
af37e56
invert checked logic
thompsongl Dec 9, 2021
d97e9fd
Merge branch 'main' into eui/43.0
thompsongl Dec 9, 2021
7f85b10
fix i18n token
thompsongl Dec 9, 2021
5e4a764
snapshots
thompsongl Dec 9, 2021
f370b20
handle new refresh interval operations order
thompsongl Dec 13, 2021
25d8b6b
Merge branch 'main' into eui/43.0
thompsongl Dec 13, 2021
9b530e0
refactor refresh interval logic, test
thompsongl Dec 13, 2021
719c5a8
jest
thompsongl Dec 13, 2021
104ba53
Merge branch 'main' into eui/43.0
thompsongl Dec 13, 2021
4616bc7
timepicker popover order
thompsongl Dec 13, 2021
1e9a278
eui to v43.1.0
thompsongl Dec 13, 2021
3f10425
jest
thompsongl Dec 13, 2021
5d514cc
Merge branch 'main' into eui/43.0
thompsongl Dec 13, 2021
35705e1
jest
thompsongl Dec 13, 2021
3a33df2
jest
thompsongl Dec 13, 2021
0f0ffb3
Merge branch 'main' into eui/43.0
thompsongl Dec 13, 2021
0ea0e51
euicode selector
thompsongl Dec 14, 2021
04db019
jest
thompsongl Dec 14, 2021
253e475
Merge branch 'main' into eui/43.0
thompsongl Dec 14, 2021
2e555b5
functional tests
thompsongl Dec 14, 2021
c179517
Merge branch 'main' into eui/43.0
thompsongl Dec 14, 2021
d67dd95
functional tests
thompsongl Dec 14, 2021
cc0b540
Merge branch 'main' into eui/43.0
thompsongl Dec 14, 2021
b579d27
timepicker
thompsongl Dec 14, 2021
db050f0
bump timeout
thompsongl Dec 14, 2021
9d0a26e
Merge branch 'main' into eui/43.0
thompsongl Dec 15, 2021
07eee93
conditional click to close
thompsongl Dec 15, 2021
5083a50
clean up
thompsongl Dec 15, 2021
d5b68ce
eui to v43.1.1
thompsongl Dec 15, 2021
75f7ac4
Merge branch 'main' into eui/43.0
thompsongl Dec 15, 2021
dc71e80
clean up
thompsongl Dec 16, 2021
b582282
Merge branch 'main' into eui/43.0
thompsongl Dec 16, 2021
69a308a
loading background
thompsongl Dec 17, 2021
b4c2ab7
Merge branch 'main' into eui/43.0
thompsongl Dec 17, 2021
a280d69
Merge branch 'main' into eui/43.0
kibanamachine Dec 20, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions test/functional/page_objects/time_picker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,9 @@ export class TimePickerPageObject extends FtrService {
})
);

const toggleButtonText = await this.testSubjects.getVisibleText(
'superDatePickerToggleRefreshButton'
const toggleButtonChecked = await this.testSubjects.getAttribute(
'superDatePickerToggleRefreshButton',
'aria-checked'
Comment on lines +201 to +203
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I <3 this tweak

);
if (!keepQuickSelectOpen) {
await this.quickSelectTimeMenuToggle.close();
Expand All @@ -204,7 +205,7 @@ export class TimePickerPageObject extends FtrService {
return {
interval,
units: selectedUnit,
isPaused: toggleButtonText === 'Start' ? true : false,
isPaused: toggleButtonChecked === 'true' ? true : false,
};
}

Expand Down Expand Up @@ -262,12 +263,12 @@ export class TimePickerPageObject extends FtrService {

public async startAutoRefresh(intervalS = 3) {
await this.quickSelectTimeMenuToggle.open();
await this.inputValue('superDatePickerRefreshIntervalInput', intervalS.toString());
const refreshConfig = await this.getRefreshConfig(true);
if (refreshConfig.isPaused) {
this.log.debug('start auto refresh');
await this.testSubjects.click('superDatePickerToggleRefreshButton');
}
await this.inputValue('superDatePickerRefreshIntervalInput', intervalS.toString());
const refreshConfig = await this.getRefreshConfig(true);
await this.quickSelectTimeMenuToggle.close();
}

Expand Down