Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] [Security Solution][Platform] - Exceptions imports (#118816) #120824

Merged
merged 7 commits into from
Dec 13, 2021

Conversation

kibanamachine
Copy link
Contributor

Backports the following commits to 8.0:

## Summary

Addresses elastic#92613 and elastic#117399

Goal is to allow users to import their exception lists and items alongside their rules. This PR does not complete all the UI updates needed, but does tackle the majority of use cases. The bulk of the changes occur in `import_rules_route` and the new `import_exceptions_route`.

- Adds exceptions import endpoint in `lists` plugin
- Adds exceptions import logic in import rules route in `security_solution` plugin
- Adds integration tests for exception import endpoint
- Adds integration tests for rules import endpoint to account for new functionality
- Purposely not yet adding an import modal in the exceptions table UI until further list management features added (checked with product on this front)
@yctercero
Copy link
Contributor

@elasticmachine merge upstream

@yctercero yctercero disabled auto-merge December 11, 2021 22:09
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lists 293 297 +4
securitySolution 2803 2807 +4
total +8

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/securitysolution-io-ts-list-types 419 428 +9
@kbn/securitysolution-io-ts-types 23 26 +3
lists 153 144 -9
total +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lists 142.4KB 143.3KB +925.0B
securitySolution 4.6MB 4.6MB +890.0B
total +1.8KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
lists 39 41 +2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 244.6KB 244.7KB +94.0B
Unknown metric groups

API count

id before after diff
@kbn/securitysolution-io-ts-list-types 428 439 +11
@kbn/securitysolution-io-ts-types 45 48 +3
lists 160 164 +4
total +18

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yctercero

@yctercero
Copy link
Contributor

Apologies for the late merge. I didn't catch that it had failed until days later.

@yctercero yctercero merged commit ec02f3d into elastic:8.0 Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants