Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] [Security Solution][Detections] Updates RuleDetails to query alerts by RuleId instead of Rule SO ID (#120053) #120704

Closed

Conversation

kibanamachine
Copy link
Contributor

Backports the following commits to 8.0:

…y RuleId instead of Rule SO ID (elastic#120053)

* Switches RuleDetails to query alerts by ruleId instead of SO id

* Increases integrity of test outputs

* Cleans up duplicate RuleRegistry functions

* Removes support for rule.id for alerts filter and updates exceptions to use new filter
@spong
Copy link
Member

spong commented Dec 8, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor Author

expected head sha didn’t match current head ref.

@spong
Copy link
Member

spong commented Dec 8, 2021

Bad merge, closing and recreating...

@spong spong closed this Dec 8, 2021
auto-merge was automatically disabled December 8, 2021 04:31

Pull request was closed

@spong
Copy link
Member

spong commented Dec 8, 2021

New backport here: #120710

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/rule-data-utils 71 72 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 308.3KB 308.4KB +103.0B
infra 990.9KB 991.3KB +412.0B
observability 369.0KB 369.1KB +103.0B
securitySolution 4.6MB 4.6MB -1.6KB
total -1.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 29.3KB 29.4KB +103.0B
securitySolution 244.6KB 244.7KB +103.0B
timelines 135.0KB 135.1KB +103.0B
uptime 23.2KB 23.3KB +103.0B
total +412.0B
Unknown metric groups

API count

id before after diff
@kbn/rule-data-utils 74 75 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @spong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants