-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reporting] fix unsupported platform crash #120659
Merged
tsullivan
merged 7 commits into
elastic:main
from
tsullivan:reporting/fix-unsupported-platform-crash
Dec 7, 2021
Merged
[Reporting] fix unsupported platform crash #120659
tsullivan
merged 7 commits into
elastic:main
from
tsullivan:reporting/fix-unsupported-platform-crash
Dec 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
(Deprecated) Feature:Reporting
Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead
Team:AppServicesUx
v8.1.0
labels
Dec 7, 2021
Pinging @elastic/kibana-app-services (Team:AppServicesUx) |
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
tsullivan
added
bug
Fixes for quality problems that affect the customer experience
release_note:skip
Skip the PR/issue when compiling release notes
labels
Dec 7, 2021
3 tasks
smith
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected for me. Thank you!
dokmic
reviewed
Dec 7, 2021
dokmic
reviewed
Dec 7, 2021
dokmic
reviewed
Dec 7, 2021
dokmic
reviewed
Dec 7, 2021
dokmic
reviewed
Dec 7, 2021
dokmic
reviewed
Dec 7, 2021
dokmic
reviewed
Dec 7, 2021
dokmic
reviewed
Dec 7, 2021
dokmic
approved these changes
Dec 7, 2021
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
dokmic
added a commit
to dokmic/kibana
that referenced
this pull request
Dec 9, 2021
* [Reporting] fix unsupported platform crash * revert test code * improve types and add test * Apply suggestions from code review Co-authored-by: Michael Dokolin <[email protected]> * updates per feedback - remove the error class member * add stack trace of error * revert change to guard a type Co-authored-by: Michael Dokolin <[email protected]>
dokmic
added a commit
that referenced
this pull request
Dec 9, 2021
* [Reporting] fix unsupported platform crash * revert test code * improve types and add test * Apply suggestions from code review Co-authored-by: Michael Dokolin <[email protected]> * updates per feedback - remove the error class member * add stack trace of error * revert change to guard a type Co-authored-by: Michael Dokolin <[email protected]> Co-authored-by: Tim Sullivan <[email protected]>
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
* [Reporting] fix unsupported platform crash * revert test code * improve types and add test * Apply suggestions from code review Co-authored-by: Michael Dokolin <[email protected]> * updates per feedback - remove the error class member * add stack trace of error * revert change to guard a type Co-authored-by: Michael Dokolin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
bug
Fixes for quality problems that affect the customer experience
(Deprecated) Feature:Reporting
Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead
release_note:skip
Skip the PR/issue when compiling release notes
v8.0.0
v8.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Caused by: #120110
This PR fixes a server crash that occurs when the platform doesn't have a supported Chromium binary available for Reporting.
Today, a user on the Darwin arm64 platform will get a crash when they try to start Kibana:
Now, they will still see the error logged but the server will not crash. This change also has a proper stack trace logged:
When this error is logged, if the user tries to generate a PNG or PDF report in the Kibana instance, they will see a failed report with an appropriate error:
Checklist
Delete any items that are not applicable to this PR.