Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): splits types from code on @kbn/es-archiver #120657

Merged
merged 2 commits into from
Dec 8, 2021
Merged

chore(NA): splits types from code on @kbn/es-archiver #120657

merged 2 commits into from
Dec 8, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Dec 7, 2021

This PR is a step forward on #104519

It splits the the types build from the code transpilation.

@mistic mistic added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 labels Dec 7, 2021
@mistic mistic requested a review from jbudz December 7, 2021 17:08
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #10 / maps app Add layer panel "before all" hook for "should show unsaved layer in layer TOC"

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic marked this pull request as ready for review December 7, 2021 19:01
@mistic mistic requested a review from a team as a code owner December 7, 2021 19:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

jbudz
jbudz approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows LGTM

@mistic mistic merged commit 98f41aa into elastic:main Dec 8, 2021
@kibanamachine kibanamachine mentioned this pull request Dec 8, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0

This backport PR will be merged automatically after passing CI.

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 8, 2021
@mistic @kibanamachine
chore(NA): splits types from code on @kbn/es-archiver (elastic#120657)
2e3db64
kibanamachine added a commit that referenced this pull request Dec 8, 2021
@kibanamachine @mistic
chore(NA): splits types from code on @kbn/es-archiver (#120657) (#120707
b8e06e3 
)

Co-authored-by: Tiago Costa <[email protected]>
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@mistic @TinLe
chore(NA): splits types from code on @kbn/es-archiver (elastic#120657)
fbd1415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mistic @kibana-ci @elasticmachine @kibanamachine @jbudz