Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): use internal pkg_npm on @kbn/es #120637

Merged
merged 4 commits into from
Dec 7, 2021
Merged

chore(NA): use internal pkg_npm on @kbn/es #120637

merged 4 commits into from
Dec 7, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Dec 7, 2021

This PR is a step forward on #104519

It changes the package build to use the internal macro for pkg_npm

@mistic mistic added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 labels Dec 7, 2021
@mistic mistic requested a review from jbudz December 7, 2021 15:42
@mistic mistic requested a review from a team as a code owner December 7, 2021 15:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic
Copy link
Member Author

mistic commented Dec 7, 2021

@elasticmachine merge upstream

jbudz
jbudz approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows LGTM

@mistic mistic enabled auto-merge (squash) December 7, 2021 20:25
@mistic
Copy link
Member Author

mistic commented Dec 7, 2021

@elasticmachine merge upstream

@mistic mistic merged commit 905a447 into elastic:main Dec 7, 2021
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine mentioned this pull request Dec 7, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Dec 7, 2021
@mistic @kibanamachine
chore(NA): use internal pkg_npm on @kbn/es (elastic#120637)
3ca17f5 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Dec 7, 2021
@kibanamachine @mistic
chore(NA): use internal pkg_npm on @kbn/es (#120637) (#120692)
7da3a0b 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Tiago Costa <[email protected]>
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@mistic @kibanamachine @TinLe
chore(NA): use internal pkg_npm on @kbn/es (elastic#120637)
73307bc 
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mistic @elasticmachine @kibana-ci @kibanamachine @jbudz