[kbn-es/installers] convert to TypeScript #120560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
auto-backport
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Dec 7, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 7, 2021
* [kbn-es/installers] convert to TypeScript * catch invalid urls passed to installArchive()
💔 Backport failed
Successful backport PRs will be merged automatically after passing CI. To backport manually run: |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Dec 7, 2021
* [kbn-es/installers] convert to TypeScript * catch invalid urls passed to installArchive() # Conflicts: # packages/kbn-es/src/custom_snapshots.ts
kibanamachine
added a commit
that referenced
this pull request
Dec 7, 2021
* [kbn-es/installers] convert to TypeScript * catch invalid urls passed to installArchive() Co-authored-by: Spencer <[email protected]>
spalger
pushed a commit
that referenced
this pull request
Dec 7, 2021
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
* [kbn-es/installers] convert to TypeScript * catch invalid urls passed to installArchive()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to improve kbn-es startup and reduce some of the log noise on CI I'm constantly breaking things unexpectedly and finding it very challenging to refactor things. In an effort to make that easier I'd like to convert the module to TypeScript, starting with the installers and their dependencies.