Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): splits types from code on @kbn/dev-utils #120531

Merged
merged 5 commits into from
Dec 7, 2021
Merged

chore(NA): splits types from code on @kbn/dev-utils #120531

merged 5 commits into from
Dec 7, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Dec 6, 2021

This PR is a step forward on #104519

It splits the the types build from the code transpilation.

@mistic mistic added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 labels Dec 6, 2021
@mistic mistic requested a review from jbudz December 6, 2021 18:25
@mistic mistic marked this pull request as ready for review December 6, 2021 19:55
@mistic mistic requested review from a team as code owners December 6, 2021 19:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

jbudz
jbudz approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows LGTM

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Dec 6, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

jportner
jportner approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@mistic mistic enabled auto-merge (squash) December 6, 2021 22:14
dmlemeshko
dmlemeshko approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kibana QA changes LGTM

@mistic
Copy link
Member Author

mistic commented Dec 7, 2021

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/dev-utils 214 194 -20

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
kibana 862 863 +1
Unknown metric groups

API count

id before after diff
@kbn/dev-utils 280 250 -30

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic disabled auto-merge December 7, 2021 20:11
@mistic
Copy link
Member Author

mistic commented Dec 7, 2021

@elastic/apm-ui I'm going ahead and merge this as it mainly changes the package layout on Bazel files. Let me know if you have further feedback for it.

@mistic mistic merged commit de5dd78 into elastic:main Dec 7, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 8.0 Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 120531

@mistic mistic mentioned this pull request Dec 7, 2021
Merged
mistic added a commit to mistic/kibana that referenced this pull request Dec 7, 2021
@mistic
chore(NA): splits types from code on @kbn/dev-utils (elastic#120531)
69b5d60 
Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	packages/kbn-es-archiver/src/actions/rebuild_all.ts
mistic added a commit that referenced this pull request Dec 7, 2021
@mistic @kibanamachine
chore(NA): splits types from code on @kbn/dev-utils (#120531) (#120676)
51f0148 
Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	packages/kbn-es-archiver/src/actions/rebuild_all.ts

Co-authored-by: Kibana Machine <[email protected]>
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@mistic @kibanamachine @TinLe
chore(NA): splits types from code on @kbn/dev-utils (elastic#120531)
38164f4 
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlemeshko dmlemeshko dmlemeshko approved these changes

@jportner jportner jportner approved these changes

@jbudz jbudz jbudz approved these changes

@lukeelmers lukeelmers lukeelmers approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Operations Team label for Operations Team v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mistic @elasticmachine @kibana-ci @kibanamachine @lukeelmers @jbudz @jportner @dmlemeshko