Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAC][Rule Registry] Adds test for required and optional alert fields #120475

Merged
merged 5 commits into from
Jan 25, 2022
Merged

[RAC][Rule Registry] Adds test for required and optional alert fields #120475

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
04e4381
Adds failing test case
claudiopro Dec 6, 2021
ad2c223
Adds test for required fields
claudiopro Dec 6, 2021
990274b
Merge branch 'main' into issue_120465
claudiopro Dec 13, 2021
1f0cdf8
removing kibana.alert.instance.id since it's experimental
simianhacker Jan 24, 2022
c3f2f9c
Merge branch 'main' of github.com:elastic/kibana into issue_120465
simianhacker Jan 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 67 additions & 0 deletions x-pack/plugins/rule_registry/common/parse_technical_fields.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/

import { parseTechnicalFields } from './parse_technical_fields';

describe('parseTechnicalFields', () => {
it('parses an alert with default fields without error', () => {
const ALERT_WITH_DEFAULT_FIELDS = {
'@timestamp': ['2021-12-06T12:30:59.411Z'],
'kibana.alert.status': ['active'],
'kibana.alert.duration.us': ['488935266000'],
'kibana.alert.reason': ['host.uptime has reported no data over the past 1m for *'],
'kibana.alert.workflow_status': ['open'],
'kibana.alert.rule.uuid': ['c8ef4420-4604-11ec-b08c-c590e7b8c4cd'],
'kibana.alert.rule.producer': ['infrastructure'],
'kibana.alert.rule.consumer': ['alerts'],
'kibana.alert.rule.category': ['Metric threshold'],
'kibana.alert.start': ['2021-11-30T20:42:04.145Z'],
'kibana.alert.rule.rule_type_id': ['metrics.alert.threshold'],
'event.action': ['active'],
'kibana.alert.instance.id': ['*'],
simianhacker marked this conversation as resolved.
Show resolved Hide resolved
'kibana.alert.rule.name': ['Uptime'],
'kibana.alert.uuid': ['f31f5726-3c47-4c88-bc42-4e1fbde17e34'],
'kibana.space_ids': ['default'],
'kibana.version': ['8.1.0'],
'event.kind': ['signal'],
};
expect(() => parseTechnicalFields(ALERT_WITH_DEFAULT_FIELDS)).not.toThrow();
});

it('parses an alert with missing required fields with error', () => {
const ALERT_WITH_MISSING_REQUIRED_FIELDS = {
'@timestamp': ['2021-12-06T12:30:59.411Z'],
'kibana.alert.duration.us': ['488935266000'],
'kibana.alert.reason': ['host.uptime has reported no data over the past 1m for *'],
'kibana.alert.workflow_status': ['open'],
'kibana.alert.start': ['2021-11-30T20:42:04.145Z'],
'event.action': ['active'],
'kibana.alert.instance.id': ['*'],
simianhacker marked this conversation as resolved.
Show resolved Hide resolved
'kibana.version': ['8.1.0'],
'event.kind': ['signal'],
};
expect(() => parseTechnicalFields(ALERT_WITH_MISSING_REQUIRED_FIELDS)).toThrow();
});

it('parses an alert with missing optional fields without error', () => {
const ALERT_WITH_MISSING_OPTIONAL_FIELDS = {
'@timestamp': ['2021-12-06T12:30:59.411Z'],
'kibana.alert.rule.uuid': ['c8ef4420-4604-11ec-b08c-c590e7b8c4cd'],
'kibana.alert.status': ['active'],
'kibana.alert.rule.producer': ['infrastructure'],
'kibana.alert.rule.consumer': ['alerts'],
'kibana.alert.rule.category': ['Metric threshold'],
'kibana.alert.rule.rule_type_id': ['metrics.alert.threshold'],
'kibana.alert.instance.id': ['*'],
simianhacker marked this conversation as resolved.
Show resolved Hide resolved
'kibana.alert.rule.name': ['Uptime'],
'kibana.alert.uuid': ['f31f5726-3c47-4c88-bc42-4e1fbde17e34'],
'kibana.space_ids': ['default'],
};

expect(() => parseTechnicalFields(ALERT_WITH_MISSING_OPTIONAL_FIELDS)).not.toThrow();
});
});