Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability] Wraps render tree with KibanaThemeProvider #120400

Merged
merged 4 commits into from
Dec 9, 2021

Conversation

claudiopro
Copy link
Contributor

@claudiopro claudiopro commented Dec 3, 2021

Summary

This PR wraps render trees of Observability apps into KibanaThemeProvider as requested by #118866. It also adds options containing the value of theme$ as second argument of toRenderMount, passing it down from AppMountParams.

Closes #120896.

Checklist

Delete any items that are not applicable to this PR.

@claudiopro claudiopro force-pushed the issue_118866_observability branch from 64f562d to d7ff330 Compare December 3, 2021 19:20
@fkanout
Copy link
Contributor

fkanout commented Dec 8, 2021

@claudiopro would you please link the PR with the issue? I was going to pick it up 😄 .e.g use the fix keyword OR link it from the UI(right side panel).

@claudiopro
Copy link
Contributor Author

Sure! I haven't heard from @estermv who owns #119499 to avoid overlapping, so I'll go ahead and create a new issue for Actionable Observability.

@claudiopro claudiopro marked this pull request as ready for review December 9, 2021 13:07
@claudiopro claudiopro requested a review from a team as a code owner December 9, 2021 13:07
@claudiopro claudiopro added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Theme: rac label obsolete v8.1.0 labels Dec 9, 2021
@claudiopro
Copy link
Contributor Author

I'm not sure whether this occurrence belongs to us:

// eslint-disable-next-line import/no-default-export
export default function HeaderMenuPortal({ children, setHeaderActionMenu }: HeaderMenuPortalProps) {
const portalNode = useMemo(() => createPortalNode(), []);
useEffect(() => {
setHeaderActionMenu((element) => {
const mount = toMountPoint(<OutPortal node={portalNode} />);
return mount(element);
});

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime change LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 362.6KB 362.7KB +126.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@claudiopro claudiopro merged commit 3fd2d5f into elastic:main Dec 9, 2021
@claudiopro claudiopro deleted the issue_118866_observability branch December 9, 2021 16:52
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
…20400)

* Treats application root

* Treats toMountPoint - part I
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Theme: rac label obsolete v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Actionable Observability] Adapt Observability Alerts to use the new KibanaThemeProvider
4 participants