-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Observability] Wraps render tree with KibanaThemeProvider #120400
[Observability] Wraps render tree with KibanaThemeProvider #120400
Conversation
cb6d552
to
64f562d
Compare
64f562d
to
d7ff330
Compare
@claudiopro would you please link the PR with the issue? I was going to pick it up 😄 .e.g use the |
I'm not sure whether this occurrence belongs to us: kibana/x-pack/plugins/observability/public/components/shared/header_menu_portal.tsx Lines 13 to 21 in a00fa53
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uptime change LGTM
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
…20400) * Treats application root * Treats toMountPoint - part I
Summary
This PR wraps render trees of Observability apps into
KibanaThemeProvider
as requested by #118866. It also adds options containing the value oftheme$
as second argument oftoRenderMount
, passing it down fromAppMountParams
.Closes #120896.
Checklist
Delete any items that are not applicable to this PR.