Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mock elastic-apm-node in @kbn/test jest preset #120324

Merged
merged 7 commits into from
Dec 7, 2021
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions packages/kbn-apm-config-loader/src/init_apm.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ import { initApm } from './init_apm';
import apm from 'elastic-apm-node';

describe('initApm', () => {
let apmAddFilterSpy: jest.SpyInstance;
let apmStartSpy: jest.SpyInstance;
let apmAddFilterMock: jest.Mock;
let apmStartMock: jest.Mock;
let getConfig: jest.Mock;

beforeEach(() => {
apmAddFilterSpy = jest.spyOn(apm, 'addFilter').mockImplementation(() => undefined);
apmStartSpy = jest.spyOn(apm, 'start').mockImplementation(() => undefined as any);
apmAddFilterMock = apm.addFilter as jest.Mock;
apmStartMock = apm.start as jest.Mock;
getConfig = jest.fn();

mockLoadConfiguration.mockImplementation(() => ({
Expand All @@ -27,7 +27,8 @@ describe('initApm', () => {
});

afterEach(() => {
jest.restoreAllMocks();
apmAddFilterMock.mockReset();
apmStartMock.mockReset();
mockLoadConfiguration.mockReset();
});

Expand All @@ -48,8 +49,8 @@ describe('initApm', () => {
it('registers a filter using `addFilter`', () => {
initApm(['foo', 'bar'], 'rootDir', true, 'service-name');

expect(apmAddFilterSpy).toHaveBeenCalledTimes(1);
expect(apmAddFilterSpy).toHaveBeenCalledWith(expect.any(Function));
expect(apmAddFilterMock).toHaveBeenCalledTimes(1);
expect(apmAddFilterMock).toHaveBeenCalledWith(expect.any(Function));
});

it('starts apm with the config returned from `getConfig`', () => {
Expand All @@ -60,7 +61,7 @@ describe('initApm', () => {

initApm(['foo', 'bar'], 'rootDir', true, 'service-name');

expect(apmStartSpy).toHaveBeenCalledTimes(1);
expect(apmStartSpy).toHaveBeenCalledWith(config);
expect(apmStartMock).toHaveBeenCalledTimes(1);
expect(apmStartMock).toHaveBeenCalledWith(config);
});
});
1 change: 1 addition & 0 deletions packages/kbn-test/jest-preset.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ module.exports = {
moduleNameMapper: {
'@elastic/eui/lib/(.*)?': '<rootDir>/node_modules/@elastic/eui/test-env/$1',
'@elastic/eui$': '<rootDir>/node_modules/@elastic/eui/test-env',
'elastic-apm-node': '<rootDir>/node_modules/@kbn/test/target_node/jest/mocks/apm_agent_mock.js',
'\\.module.(css|scss)$':
'<rootDir>/node_modules/@kbn/test/target_node/jest/mocks/css_module_mock.js',
'\\.(css|less|scss)$': '<rootDir>/node_modules/@kbn/test/target_node/jest/mocks/style_mock.js',
Expand Down
62 changes: 62 additions & 0 deletions packages/kbn-test/src/jest/mocks/apm_agent_mock.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Should we migrate this file to TS? I guess we don't want to, so we don't need to import the original library to match the types (and add the dependency). Is that right?

Copy link
Contributor Author

@pgayvallet pgayvallet Dec 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started with TS (which ensured I have a full mock as I used a jest.Mock<Agent> as the type of this structure when coding it), but:

  1. You can't use module.export =, and not 100% sure export default is exactly the same (plus I had to disable an eslint warning as default exports are not allowed here)
  2. I was forced to disable some other eslint warnings because jest is undeclared (file is not considered as a test file)
  3. I had an error while running kbn bootstrap because this module can't import type { Agent } from "elastic-apm-node" for some reason (probably related to bazel project dependencies)

so given that

  1. all other mocks in this folder are still in javascript

I assumed this was okay-ish

But I can retry using TS if we think this is preferable, @elastic/kibana-operations wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your points are very valid! I'm just happy that we have them documented now in this PR discussion 🙂

Copy link
Contributor

@mshustov mshustov Dec 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be okay to start with the current implementation, but in the long term, we need TypeScript to enforce the mock compatibility with an interface of the original package.

You can't use module.export =, and not 100% sure export default is exactly the same (plus I had to disable an eslint warning as default exports are not allowed here)

Maybe the Ops team can help with it?

I had an error while running kbn bootstrap because this module can't import type { Agent } from "elastic-apm-node" for some reason (probably related to bazel project dependencies)

elastic-apm-node is not declared as a TYPES_DEPS dependency in
https://github.com/elastic/kibana/blob/e527c3fe297d3e17c6d5a8a24b4ea58a676fc641/packages/kbn-test/BUILD.bazel

I was forced to disable some other eslint warnings because jest is undeclared (file is not considered as a test file)

jest types are declared for all *.ts files

"types": ["jest", "node"]
It should work out of the box 🤔

all other mocks in this folder are still in javascript

They are quite small and don't mock such a large API surface.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jest types are declared for all *.ts files

My bad, it's actually only with .js extension. It worked fine with .ts files.

elastic-apm-node is not declared as a TYPES_DEPS dependency in

Thanks, that was just it.

Done in df6e05d

* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0 and the Server Side Public License, v 1; you may not use this file except
* in compliance with, at your election, the Elastic License 2.0 or the Server
* Side Public License, v 1.
*/

/**
* `elastic-apm-node` patches the runtime at import time
* causing memory leak with jest module sandbox, so it
* needs to be mocked for tests
*/

/* eslint-disable no-undef */
const agent = {
start: jest.fn().mockImplementation(() => agent),
isStarted: jest.fn().mockReturnValue(false),
getServiceName: jest.fn().mockReturnValue('mock-service'),
setFramework: jest.fn(),
addPatch: jest.fn(),
removePatch: jest.fn(),
clearPatches: jest.fn(),
lambda: jest.fn(),
handleUncaughtExceptions: jest.fn(),
captureError: jest.fn(),
currentTraceparent: null,
currentTraceIds: {},
startTransaction: jest.fn().mockReturnValue(null),
setTransactionName: jest.fn(),
endTransaction: jest.fn(),
currentTransaction: null,
startSpan: jest.fn(),
currentSpan: null,
setLabel: jest.fn().mockReturnValue(false),
addLabels: jest.fn().mockReturnValue(false),
setUserContext: jest.fn(),
setCustomContext: jest.fn(),
addFilter: jest.fn(),
addErrorFilter: jest.fn(),
addSpanFilter: jest.fn(),
addTransactionFilter: jest.fn(),
addMetadataFilter: jest.fn(),
flush: jest.fn(),
destroy: jest.fn(),
registerMetric: jest.fn(),
setTransactionOutcome: jest.fn(),
setSpanOutcome: jest.fn(),
middleware: {
connect: jest.fn().mockReturnValue(jest.fn()),
},
logger: {
fatal: jest.fn(),
error: jest.fn(),
warn: jest.fn(),
info: jest.fn(),
debug: jest.fn(),
trace: jest.fn(),
},
};

module.exports = agent;