[Visualize] Fixes wrong display of split warning callout #120199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
added
Feature:Visualizations
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
stratoula
added
the
Team:Visualizations
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The new heatmap implementation doesn't allow small multiples. For this reason we added a notification to all these heatmaps that have been created with the split chart aggregation and are using the new implementation. I had forgotten to check by the vis type (
heatmap) and it was been displayed to all other visualizations (pie, xy) if they were using the split charts bucket.This PR fixes it.
Before
After:
Checklist