Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerting] Adding custom deprecation messages for enabled flag #120151

Merged
merged 5 commits into from
Dec 2, 2021
Merged

[Alerting] Adding custom deprecation messages for enabled flag #120151

merged 5 commits into from
Dec 2, 2021

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Dec 1, 2021 •
edited
Loading

Resolves #114190

Summary

Plugin
Actions Custom message with instructions to use enabledActionTypes config to disable all actions types
Alerting No custom message because enabled is not a supported config and will cause an error on startup.
Stack alerts Custom message with instructions to use Stack Rules feature privilege to control access.
Task manager No custom message, just updated to use i18n and match message to our other plugins.
Event log No custom message, just updated to use i18n and match message to our other plugins.

Actions deprecation message
Screen Shot 2021-12-01 at 1 16 55 PM

Stack Alerts deprecation message
Screen Shot 2021-12-01 at 1 33 15 PM

Checklist

@ymao1 ymao1 self-assigned this Dec 1, 2021
@ymao1 ymao1 added Feature:Actions Feature:Alerting Feature:EventLog Feature:Task Manager release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.16.1 labels Dec 1, 2021
@ymao1 ymao1 marked this pull request as ready for review December 1, 2021 18:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@ymao1
Copy link
Contributor Author

ymao1 commented Dec 1, 2021

@elasticmachine merge upstream

@ymao1 ymao1 requested a review from a team December 1, 2021 19:00
YulNaumenko
YulNaumenko approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chrisronline
chrisronline approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ymao1
Copy link
Contributor Author

ymao1 commented Dec 2, 2021

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ymao1

@ymao1 ymao1 merged commit 87df8f1 into elastic:7.16 Dec 2, 2021
@ymao1 ymao1 mentioned this pull request Dec 2, 2021
Closed
@ymao1 ymao1 deleted the alerting/custom-deprecation-messages branch January 27, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisronline chrisronline chrisronline approved these changes

@YulNaumenko YulNaumenko YulNaumenko approved these changes

Assignees

@ymao1 ymao1

Labels
Feature:Actions Feature:Alerting Feature:EventLog Feature:Task Manager release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.16.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ymao1 @elasticmachine @kibana-ci @chrisronline @YulNaumenko @kibanamachine