[Canvas] Added KibanaThemeProvider to expression_error. #120073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Replaced renderer with getRenderer function and factory. 2. Updated storybook. 3. Moved defaultTheme$ to presentain_util.
Kuznietsov
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
7 tasks
# Conflicts: # x-pack/plugins/canvas/canvas_plugin_src/renderers/markdown/index.tsx # x-pack/plugins/canvas/canvas_plugin_src/renderers/table.tsx # x-pack/plugins/canvas/canvas_plugin_src/renderers/text.tsx # x-pack/plugins/canvas/shareable_runtime/supported_renderers.js
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
To update your PR or re-run it, just comment with: cc @Kunzetsov |
crob611
approved these changes
Dec 2, 2021
| @@ -26,4 +27,4 @@ export const renderFunctions = [ | |||
| progressRenderer, | |||
| ]; | |||
|
|
|||
| export const renderFunctionFactories = []; | |||
| export const renderFunctionFactories = [debugRendererFactory, errorRendererFactory]; | |||
There was a problem hiding this comment.
Is including these renderers here causing them to be double registered, since htey are also being registered in the errorPlugin?
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
* Wrapped up debug and error with KibanaThemeProvider. 1. Replaced renderer with getRenderer function and factory. 2. Updated storybook. 3. Moved defaultTheme$ to presentain_util. * Fixed exports. Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Performed required changes at the issue #120071.
Added KibanaThemeProvider to the expression_error plugin in all places, where
ReactDOM.renderis executed.