[Stack mgt apps] Wrap all apps with KibanaThemeProvider #120003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebelga
added
backport:skip
|
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
sabarasaba
approved these changes
Dec 2, 2021
There was a problem hiding this comment.
Thanks for taking on this @sebelga! Code changes lgtm, tested locally and it all works as expected 🚀
| import { | ||
| createKibanaReactContext, | ||
| KibanaThemeProvider, | ||
| } from '../../../../../src/plugins/kibana_react/public'; |
There was a problem hiding this comment.
nit: Would be nice to move this into a shared_imports file
There was a problem hiding this comment.
Good idea. Addressed in b7a22c7
|
Thanks for the review @sabarasaba! 👍 |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wraps all the apps of the Stack management team with the new
<KibanaThemeProvider/>.Plugins
license_managmentcross_cluster_replicationwatcherremote_clustersrollupsnapshot_restoreingest_pipelinesindex_managementindex_lifecycleupgrade_assistantdev_toolsconsolesearchprofilergrokdebuggerpainless_labmanagementNote: there is one commit for each plugin change
How to test
There should not be much manual test to do as we should have smoke tests for all of our apps. Navigate to each of the app and verify that it renders correctly.
See #118866 for context.