Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Route to get service locations and a handler #119964

Merged
merged 3 commits into from
Nov 30, 2021
Merged

[Uptime] Route to get service locations and a handler #119964

merged 3 commits into from
Nov 30, 2021

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Nov 30, 2021 •
edited by awahab07
Loading

Closes elastic/uptime#423

Summary

Add a route to get service locations, which will be parsed from manifest file

also a common handler which will be used on service side as well to validate to locations.

@shahzad31 shahzad31 marked this pull request as ready for review November 30, 2021 14:59
@shahzad31 shahzad31 requested a review from a team as a code owner November 30, 2021 14:59
@shahzad31 shahzad31 self-assigned this Nov 30, 2021
@shahzad31 shahzad31 added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Nov 30, 2021
@shahzad31 shahzad31 changed the title Manifest locations [Uptime] Route to get service locations and a handler Nov 30, 2021
dominiqueclarke
dominiqueclarke approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

x-pack/plugins/uptime/server/lib/synthetics_service/get_service_locations.ts

return locations;
} catch (e) {
return [];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we go ahead and display an fatal error message when this happens? Can't use the service without a location right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, if it's empty, it makes sense to just disable the UI, and display an error.

x-pack/plugins/uptime/common/types/index.ts
name: string;
location: LocationGeo;
};
status: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the status for, for my information?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think if the location is in GA or beta etc.

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Nov 30, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 586.7KB 586.7KB +57.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

@shahzad31 shahzad31 added the auto-backport Deprecated - use backport:version if exact versions are needed label Nov 30, 2021
@shahzad31 shahzad31 merged commit b71f78a into elastic:main Nov 30, 2021
@shahzad31 shahzad31 deleted the manifest-locations branch November 30, 2021 16:49
@kibanamachine
Copy link
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v8.1.0

If any of these should not be on your pull request, please manually remove them.

1 similar comment
@kibanamachine
Copy link
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v8.1.0

If any of these should not be on your pull request, please manually remove them.

@kibanamachine kibanamachine mentioned this pull request Nov 30, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0

This backport PR will be merged automatically after passing CI.

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 30, 2021
@shahzad31 @kibanamachine
[Uptime] Route to get service locations and a handler (elastic#119964)
2b48b0e
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 30, 2021
@kibanamachine @shahzad31
[Uptime] Route to get service locations and a handler (#119964) (#119988
8324c85 
)

Co-authored-by: Shahzad <[email protected]>
@awahab07 awahab07 mentioned this pull request Dec 13, 2021
Closed
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@shahzad31 @TinLe
[Uptime] Route to get service locations and a handler (elastic#119964)
31dc0a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees

@shahzad31 shahzad31

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Route to get service locations
5 participants
@shahzad31 @elasticmachine @kibana-ci @kibanamachine @dominiqueclarke