Make fixture app wait until network is idle before running authentication tests. #119715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azasypkin
added
Feature:Security/Authentication
azasypkin
force-pushed
the
issue-98562-basic-login-test
branch
from
ee0da17 to
20899b6
Compare
azasypkin
removed
the
auto-backport
|
Pinging @elastic/kibana-security (Team:Security) |
|
@elasticmachine merge upstream |
XavierM
approved these changes
Nov 29, 2021
XavierM
added
the
auto-backport
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 29, 2021
…tion tests. (elastic#119715) Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 29, 2021
…tion tests. (elastic#119715) Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 29, 2021
…tion tests. (#119715) (#119908) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Aleh Zasypkin <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 29, 2021
…tion tests. (#119715) (#119909) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Aleh Zasypkin <[email protected]>
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
…tion tests. (elastic#119715) Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make fixture app wait until network is idle before running authentication tests.
This fix is targeting flakiness in
can login after `Unauthorized` error during request authentication preserving original URLtest where we disable test user and refresh the page. The problem with the previous implementation was that we could potentially disable user before Kibana sent a license check request (that it sends on every page). If this happens license check request will trigger session invalidation and the test will break.Flaky Test Runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/259 (x30 runs, ✔️)
Note to myself: Re-enable tests in 7.16 backport and run x30 flaky test suite there - #121054
Fixes: #98562