Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detections] Adds Rules monitoring table actions #119644

Merged
merged 16 commits into from
Dec 3, 2021
Merged

[Security Solution][Detections] Adds Rules monitoring table actions #119644

merged 16 commits into from
Dec 3, 2021

Conversation

vitaliidm
Copy link
Contributor

@vitaliidm vitaliidm commented Nov 24, 2021 •
edited
Loading

Issues

Summary

  • Refactored rules/rules monitoring tables: now it's a single table component, that is configured depends on a tab selection.
  • It uses the same table items for both tables views. Table item row now is intersection of Rule and RuleStatus properties, instead of Rule type(for management table) and enhanced RuleStatus(monitoring table).
  • Columns configuration how have reusable column items(name, tags, actions, switcher)
  • Monitoring Rules table supports now single/bulk editing of items.
  • Added simple e2e test for Monitoring Rules table to ensure the whole table works correctly
  • Refactored table header cell for columns with icon and details tooltips(Rules Monitoring table), so icon is not getting truncated on smaller resolutions. See 'Indexing Time (ms)', 'Query Time', 'Last gap' columns on screenshot

Before

Screenshot 2021-12-01 at 12 27 30

After

Screenshot 2021-12-01 at 12 28 01

Checklist

Release note

Adds users ability to enable and disable an individual rule on Rules Monitoring table, and perform other actions from actions menu column: edit rule, duplicate, export, delete
Adds users ability to select rules on Rules Monitoring table and apply bulk actions to selected: duplicate, export, delete, enable/disable.

@vitaliidm
Copy link
Contributor Author

@elasticmachine merge upstream

@vitaliidm vitaliidm force-pushed the security-solution/monitoring-rules-table-actions branch from a5eb112 to 66ef374 Compare November 25, 2021 17:25
@vitaliidm vitaliidm force-pushed the security-solution/monitoring-rules-table-actions branch from f710640 to cd49365 Compare November 29, 2021 13:29
@vitaliidm vitaliidm changed the title [Draft][Security Solution][Detections] Add Rules monitoring table actions [Security Solution][Detections] Adds Rules monitoring table actions Dec 1, 2021
@vitaliidm vitaliidm added v8.1.0 Feature:Rule Monitoring Security Solution Detection Rule Monitoring area Feature:Rule Management Security Solution Detection Rule Management area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team release_note:feature Makes this part of the condensed release notes Theme: simp_prot_mgmt Security Solution Simplified Protection Management Theme and removed Feature:Rule Monitoring Security Solution Detection Rule Monitoring area labels Dec 1, 2021
@vitaliidm vitaliidm marked this pull request as ready for review December 1, 2021 13:36
@vitaliidm vitaliidm requested a review from a team as a code owner December 1, 2021 13:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@vitaliidm
Copy link
Contributor Author

@elasticmachine merge upstream

@vitaliidm vitaliidm self-assigned this Dec 1, 2021
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.6MB 4.6MB -562.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @vitaliidm

spong
spong approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out, tested locally, and code reviewed -- LGTM! 👍 Thanks for the consolidation and cleanup here @vitaliidm, so happy to see to see the decrease in complexity around part of the code base! 🙂

@vitaliidm vitaliidm merged commit 1928bea into elastic:main Dec 3, 2021
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 3, 2021
@vitaliidm vitaliidm deleted the security-solution/monitoring-rules-table-actions branch December 3, 2021 10:15
@vitaliidm vitaliidm added auto-backport Deprecated - use backport:version if exact versions are needed and removed backport:skip This commit does not require backporting labels Dec 3, 2021
@spong
Copy link
Member

spong commented Dec 3, 2021

@Mergifyio refresh

@vitaliidm vitaliidm mentioned this pull request Dec 3, 2021
Merged
vitaliidm added a commit to vitaliidm/kibana that referenced this pull request Dec 3, 2021
@vitaliidm
[Security Solution][Detections] Adds Rules monitoring table actions (e…
ea24b7f 
…lastic#119644)

[Security Solution][Detections] Adds actions for Rules monitoring table: single/bulk enable, disable, duplicate, export, remove (elastic#119644)
vitaliidm added a commit that referenced this pull request Dec 3, 2021
@vitaliidm
[Security Solution][Detections] Adds Rules monitoring table actions (#…
0d113bf 
…119644) (#120370)

[Security Solution][Detections] Adds actions for Rules monitoring table: single/bulk enable, disable, duplicate, export, remove (#119644)
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@vitaliidm @TinLe
[Security Solution][Detections] Adds Rules monitoring table actions (e…
a2c9026 
…lastic#119644)

[Security Solution][Detections] Adds actions for Rules monitoring table: single/bulk enable, disable, duplicate, export, remove (elastic#119644)
@joepeeples joepeeples mentioned this pull request Jan 10, 2022
Closed
@joepeeples joepeeples mentioned this pull request Jan 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spong spong spong approved these changes

Assignees

@vitaliidm vitaliidm

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Rule Management Security Solution Detection Rule Management area Feature:Rule Monitoring Security Solution Detection Rule Monitoring area release_note:feature Makes this part of the condensed release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Theme: simp_prot_mgmt Security Solution Simplified Protection Management Theme v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vitaliidm @elasticmachine @kibana-ci @spong @banderror @kibanamachine