[build] automatically retry all downloads #119642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
spalger
force-pushed
the
implement/build-retry-all-downloads
branch
from
93333fb to
3a8a404
Compare
spalger
force-pushed
the
implement/build-retry-all-downloads
branch
from
3a8a404 to
ae320d7
Compare
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Nov 24, 2021
spalger
added
the
auto-backport
💔 Backport failed
To backport manually run: |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Nov 25, 2021
(cherry picked from commit 3358874)
kibanamachine
added
the
backport missing
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
2 similar comments
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
spalger
pushed a commit
that referenced
this pull request
Nov 30, 2021
Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
removed
the
backport missing
spalger
pushed a commit
that referenced
this pull request
Nov 30, 2021
Co-authored-by: Kibana Machine <[email protected]>
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a failure on CI recently because we weren't able to download the shasums for nodejs. This HTTP request was being done with axios directly because we're not trying to download to the filesystem and validate the shasums of the shasums, so we couldn't use the existing
download()helper. This renames that helper todownloadToDisk()and adds adownloadToString()helper which wraps axios, adds retries and logging about the requests, and is now in use in all locations where Axios was used in the build scripts.