[Timelion] Hide fit from suggestions #119568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
Feature:Timelion
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
|
@flash1293 if I understand correctly from the description, the fit function should be available for the flot implementation, right? I don't see it in the list when the advanced setting is on. |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8460
This PR makes sure the
fitargument of the.esfunction isn't advertised to the user as it doesn't have a meaningful function in the current feature-set. Other datasources (graphite) continue to behave the same way, as well as legacy timelion charts which define this argument alreadyBefore:
After:
