Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Fix casing in integration tab and policies table #119550

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

jen-huang
Copy link
Contributor

Summary

Resolves #119433. Small adjustment to change some copy to sentence case (per EUI guidelines).

Checklist

Delete any items that are not applicable to this PR.

@jen-huang jen-huang added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 v8.1.0 labels Nov 23, 2021
@jen-huang jen-huang self-assigned this Nov 23, 2021
@jen-huang jen-huang requested a review from a team as a code owner November 23, 2021 21:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jen-huang

@jen-huang jen-huang enabled auto-merge (squash) November 23, 2021 23:15
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jen-huang jen-huang merged commit 6a8e977 into elastic:main Nov 24, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 24, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 24, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0
7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 24, 2021
kibanamachine added a commit that referenced this pull request Nov 24, 2021
@jen-huang jen-huang deleted the fix/policy-casing branch November 24, 2021 17:48
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
@dikshachauhan-qasource
Copy link

Hi @jen-huang

Thanks for the feedback on reported issue. Further, we have validated this fixed merged PR in 7.16.1 BC2 build and found it working fine.

Build details:
BUILD 46258
COMMIT 8751518

Observation:

  • All the column names under Integrations policies subtab and Policies tab are sentence cased.
  • We have also confirmed same under Agents tab, Enrollment token tab and Data stream tab.

Screenshots:
image

image

Thanks
QAS

TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Integration policy' column name is provided instead of 'Integration name' under Integration Policies sub-tab.
6 participants