Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify date format for time split filters #119504

Merged
merged 5 commits into from
Nov 30, 2021

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Nov 23, 2021

Fixes #119444

When implementing time shift in agg configs, setting the format for the date range query was omitted which fails if there are documents with dates indexed as epoch_millis. This PR adds the format to make sure they are interpreted correctly in all cases.

I will add a functional test for epoch millis dates in general in a separate Pr

@flash1293 flash1293 added release_note:fix v8.0.0 Team:AppServicesSv auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 v7.16.1 labels Nov 23, 2021
@flash1293 flash1293 marked this pull request as ready for review November 23, 2021 19:07
@flash1293 flash1293 requested a review from a team as a code owner November 23, 2021 19:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@flash1293 flash1293 added v7.16.0 and removed v7.16.1 labels Nov 29, 2021
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 438.0KB 438.1KB +70.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 merged commit a8d199c into elastic:main Nov 30, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 30, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 30, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0
7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 30, 2021
kibanamachine added a commit that referenced this pull request Nov 30, 2021
@timroes timroes added the Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) label Dec 3, 2021
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) release_note:fix v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Time shift doesn't work on epoch_millis dates
6 participants