Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] fix dark map style #119473

Merged
merged 2 commits into from
Nov 23, 2021
Merged

[Maps] fix dark map style #119473

merged 2 commits into from
Nov 23, 2021

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Nov 23, 2021

Fixes #119412

Regression caused by #117745

Original code was source: this._generateMbSourceId(layer.source),. This fix keeps the original code's behavior of always setting source to _generateMbSourceId.

@nreese nreese added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.1.0 labels Nov 23, 2021
@nreese nreese requested a review from nickpeihl November 23, 2021 13:51
@nreese nreese requested a review from a team as a code owner November 23, 2021 13:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nreese nreese merged commit a9f8338 into elastic:main Nov 23, 2021
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
* [Maps] fix dark map style

* tslint
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
* [Maps] fix dark map style

* tslint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maps] Dark map style colors suddenly changed
4 participants