Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugin_functional] remove doc_views test #119424

Merged
merged 5 commits into from
Nov 30, 2021
Merged

[plugin_functional] remove doc_views test #119424

merged 5 commits into from
Nov 30, 2021

Conversation

dimaanj
Copy link
Contributor

@dimaanj dimaanj commented Nov 23, 2021 •
edited
Loading

Summary

Fixes #100060

This PR removes data views test, since test/plugin_functional/doc_views_plugin for this test was removed in 7.16.

Checklist

@dimaanj dimaanj added release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Nov 23, 2021
@dimaanj dimaanj self-assigned this Nov 23, 2021
kertal
kertal approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First I was confused, because of the naming in the description, so data view should be doc_views and thx for cleaning this up 👍
To be precise this fixes #100060, the linked issue happened in 7.15

@dimaanj dimaanj changed the title [plugin_functional] remove data views test [plugin_functional] remove doc_views test Nov 25, 2021
@dimaanj dimaanj marked this pull request as ready for review November 25, 2021 12:51
@dimaanj
Copy link
Contributor Author

dimaanj commented Nov 25, 2021

@elasticmachine merge upstream

@kertal
Copy link
Member

kertal commented Nov 29, 2021

@elasticmachine merge upstream

@dimaanj
Copy link
Contributor Author

dimaanj commented Nov 29, 2021

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dmitriynj

@dimaanj dimaanj added v7.15.3 Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed v7.15.3 labels Nov 30, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@dimaanj dimaanj added the Feature:Discover Discover Application label Nov 30, 2021
@dimaanj dimaanj merged commit 3bde2ec into elastic:main Nov 30, 2021
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 30, 2021
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@dimaanj @kibanamachine @TinLe
[plugin_functional] remove doc_views test (elastic#119424)
abbcd96 
* [plugin_functional] remove data views test

* [plugin_functional] fix tests

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

@timroes timroes Awaiting requested review from timroes

@majagrubic majagrubic Awaiting requested review from majagrubic

Assignees

@dimaanj dimaanj

Labels
backport:skip This commit does not require backporting Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FTR] Re-enable doc views functional tests
5 participants
@dimaanj @kertal @kibana-ci @elasticmachine @kibanamachine