Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[optimizer] pretty-print jest snapshots to help reviews #119404

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Nov 22, 2021

#119107 ended up triggering an update to the bundle saved in a Jest snapshot. This snapshot isn't massive, but it's too large to spot a little change so I'd like to format the code with prettier before snapshotting it so that we can spot changes more easily.

@spalger spalger added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.1.0 labels Nov 22, 2021
@spalger spalger requested a review from a team as a code owner November 22, 2021 23:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger spalger enabled auto-merge (squash) November 22, 2021 23:45
@spalger spalger added the auto-backport Deprecated - use backport:version if exact versions are needed label Nov 22, 2021
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #5 / saved objects spaces only enabled _bulk_create within the default space should return 200 success [isolatedtype/space1-isolatedtype-id,isolatedtype/space2-isolatedtype-id,dashboard/new-dashboard-id,sharedtype/new-sharedtype-id,globaltype/new-globaltype-id,isolatedtype/new-other-space-id,sharecapabletype/new-other-space-id,sharedtype/new-each-space-id,sharedtype/new-all-spaces-id,resolvetype/alias-match] and bad request [hiddentype/any,isolatedtype/new-other-space-id,sharecapabletype/new-other-space-id] and conflict [isolatedtype/defaultspace-isolatedtype-id,sharedtype/all_spaces,sharedtype/default_and_space_1,sharedtype/only_space_1,sharedtype/only_space_2,sharecapabletype/only_default_space,sharecapabletype/only_space_1,globaltype/globaltype-id,resolvetype/alias-match]

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit 03afede into elastic:main Nov 23, 2021
@spalger spalger deleted the implement/pretty-print-optimizer-bundle-snapshots branch November 23, 2021 00:40
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 23, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
8.0
7.16 Commit could not be cherrypicked due to conflicts

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 119404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants