Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.16] [eslint] prevent using constructor property params in initializers (#119130) #119224

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Nov 19, 2021

Backports the following commits to 7.16:

…lastic#119130)

# Conflicts:
#	packages/kbn-cli-dev-mode/src/log.ts
#	src/plugins/presentation_util/public/components/controls/control_group/embeddable/control_group_container_factory.ts
@spalger spalger enabled auto-merge (squash) November 19, 2021 19:17
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
uiActions 88 90 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uiActionsEnhanced 128.8KB 128.8KB +20.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 308.2KB 308.2KB +18.0B
dashboard 167.4KB 167.4KB +39.0B
security 50.7KB 50.7KB +54.0B
uiActions 19.0KB 19.2KB +118.0B
uiActionsEnhanced 21.7KB 22.0KB +288.0B
total +517.0B
Unknown metric groups

API count

id before after diff
uiActions 127 129 +2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit ca66ac6 into elastic:7.16 Nov 19, 2021
@spalger spalger deleted the backport/7.16/pr-119130 branch November 19, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants