Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lens tests: heatmap fix #119010

Merged
merged 2 commits into from
Nov 18, 2021
Merged

Lens tests: heatmap fix #119010

merged 2 commits into from
Nov 18, 2021

Conversation

flash1293
Copy link
Contributor

Fixes #113043

There are two issues

Palette flyout doesn't open:
Screenshot 2021-11-18 at 11 00 28

Typing in the wrong input:
Screenshot 2021-11-18 at 11 00 36

I suspect the second one to be a race condition of some sort and selenium is trying to click the input before rendering the UI has settled which is causing weird behavior.

This fix adds a retry and explicitly waits for the container to show up before continuing which should help with both problems

@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 v8.1.0 labels Nov 18, 2021
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 962.1KB 962.1KB +58.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review November 18, 2021 12:07
@flash1293 flash1293 requested a review from a team as a code owner November 18, 2021 12:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

@flash1293 flash1293 merged commit 5e90ec9 into elastic:main Nov 18, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 18, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 18, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0
7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 18, 2021
kibanamachine added a commit that referenced this pull request Nov 18, 2021
TinLe pushed a commit to TinLe/kibana that referenced this pull request Nov 20, 2021
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.0 v8.0.0 v8.1.0
Projects
None yet
6 participants