Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NA): splits types from code on @elastic/apm-synthtrace #118786

Merged

Conversation

mistic
Copy link
Member

@mistic mistic commented Nov 16, 2021

This PR is a step forward on #104519

It splits the the types build from the code transpilation.

mistic and others added 30 commits September 30, 2021 13:16
@mistic mistic added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 v7.16.1 labels Nov 16, 2021
@mistic mistic requested a review from jbudz November 16, 2021 20:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic
Copy link
Member Author

mistic commented Nov 16, 2021

@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Nov 17, 2021

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@elastic/apm-synthtrace 41 43 +2

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@elastic/apm-synthtrace 7 6 -1
Unknown metric groups

API count

id before after diff
@elastic/apm-synthtrace 41 43 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic removed the v7.16.1 label Nov 18, 2021
@mistic mistic merged commit 6aba4fb into elastic:main Nov 18, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 18, 2021
…#118786)

* chore(NA): auto creation of the package.json for the new types pkg rule

* chore(NA): first alpha api extractor working version

* chore(NA): support kbn-analytics

* chore(NA): correctly read tsconfig files and deps from ts_config rule

* chore(NA): layed out pkg_npm_types tree artifact custom rule

* chore(NA): missing todos

* chore(NA): node modules link mapping

* chore(NA): fully working pkg_npm_types rule

* chore(NA): fix changes on new packages using elastic datemath pkgs

* docs(NA): remove todo

* docs(NA): last todo text correction

* chore(NA): removed commented lines

* fix(NA): include missing package version

* chore(NA): include license keys

* chore(NA): change mock types package into private

* chore(NA): split types_pkg from code_pkg on @elastic/apm-synthtrace

* chore(NA): disable validator on ts_project rule

* chore(NA): move into ts_project wrapper

* chore(NA): complete types exports

* chore(NA): export types as type only

* chore(NA): fix type exports

* chore(NA): only include exception type

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 18, 2021
#119114)

* chore(NA): auto creation of the package.json for the new types pkg rule

* chore(NA): first alpha api extractor working version

* chore(NA): support kbn-analytics

* chore(NA): correctly read tsconfig files and deps from ts_config rule

* chore(NA): layed out pkg_npm_types tree artifact custom rule

* chore(NA): missing todos

* chore(NA): node modules link mapping

* chore(NA): fully working pkg_npm_types rule

* chore(NA): fix changes on new packages using elastic datemath pkgs

* docs(NA): remove todo

* docs(NA): last todo text correction

* chore(NA): removed commented lines

* fix(NA): include missing package version

* chore(NA): include license keys

* chore(NA): change mock types package into private

* chore(NA): split types_pkg from code_pkg on @elastic/apm-synthtrace

* chore(NA): disable validator on ts_project rule

* chore(NA): move into ts_project wrapper

* chore(NA): complete types exports

* chore(NA): export types as type only

* chore(NA): fix type exports

* chore(NA): only include exception type

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Tiago Costa <[email protected]>
TinLe pushed a commit to TinLe/kibana that referenced this pull request Nov 20, 2021
…#118786)

* chore(NA): auto creation of the package.json for the new types pkg rule

* chore(NA): first alpha api extractor working version

* chore(NA): support kbn-analytics

* chore(NA): correctly read tsconfig files and deps from ts_config rule

* chore(NA): layed out pkg_npm_types tree artifact custom rule

* chore(NA): missing todos

* chore(NA): node modules link mapping

* chore(NA): fully working pkg_npm_types rule

* chore(NA): fix changes on new packages using elastic datemath pkgs

* docs(NA): remove todo

* docs(NA): last todo text correction

* chore(NA): removed commented lines

* fix(NA): include missing package version

* chore(NA): include license keys

* chore(NA): change mock types package into private

* chore(NA): split types_pkg from code_pkg on @elastic/apm-synthtrace

* chore(NA): disable validator on ts_project rule

* chore(NA): move into ts_project wrapper

* chore(NA): complete types exports

* chore(NA): export types as type only

* chore(NA): fix type exports

* chore(NA): only include exception type

Co-authored-by: Kibana Machine <[email protected]>
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
* chore(NA): auto creation of the package.json for the new types pkg rule

* chore(NA): first alpha api extractor working version

* chore(NA): support kbn-analytics

* chore(NA): correctly read tsconfig files and deps from ts_config rule

* chore(NA): layed out pkg_npm_types tree artifact custom rule

* chore(NA): missing todos

* chore(NA): node modules link mapping

* chore(NA): fully working pkg_npm_types rule

* chore(NA): fix changes on new packages using elastic datemath pkgs

* docs(NA): remove todo

* docs(NA): last todo text correction

* chore(NA): removed commented lines

* fix(NA): include missing package version

* chore(NA): include license keys

* chore(NA): change mock types package into private

* chore(NA): split types_pkg from code_pkg on @elastic/apm-synthtrace

* chore(NA): disable validator on ts_project rule

* chore(NA): move into ts_project wrapper

* chore(NA): complete types exports

* chore(NA): export types as type only

* chore(NA): fix type exports

* chore(NA): only include exception type

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants