-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] Add gdal integration #118633
[Maps] Add gdal integration #118633
Conversation
Pinging @elastic/kibana-docs (Team:Docs) |
Pinging @elastic/kibana-gis (Team:Geo) |
@@ -348,6 +348,7 @@ export class DocLinksService { | |||
maps: { | |||
guide: `${KIBANA_DOCS}maps.html`, | |||
importGeospatialPrivileges: `${KIBANA_DOCS}import-geospatial-data.html#import-geospatial-privileges`, | |||
gdalTutorial: `${ELASTIC_WEBSITE_URL}blog/how-to-ingest-geospatial-data-into-elasticsearch-with-gdal`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though doc-links is not yet available server-side, adding the link here so it gets validated on release. This is the same approach we've taken with other data-integrations (e.g. language clients).
'Upload shapefiles or ingest from relational databases such as PostGIS and OracleSpatial', | ||
}), | ||
uiInternalPath: | ||
'https://www.elastic.co/blog/how-to-ingest-geospatial-data-into-elasticsearch-with-gdal', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we link to something inside the product instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet. We only have the blog post for now. It is not uncommon for the data-integrations page to link to blog posts, e.g. the Fleet announcements
I do agree that in-app documentation would be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a nit, but otherwise lgtm!
Co-authored-by: Nick Peihl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thomasneirynck this looks good to me overall. I didn't run locally but dropped a comment around title / description that might be nice to adjust. I'm not sure if we want @gchaps feedback there or now. Let's discuss in our next sync, but something to consider for discoverability purposes is to create different documentation specific to data sources. Then we can add cards for each geospatial data source and increase discoverability of those.
customIntegrations.registerCustomIntegration({ | ||
id: 'ingest_with_gdal', | ||
title: i18n.translate('xpack.maps.registerIntegrations.gdal.integrationTitle', { | ||
defaultMessage: 'GDAL', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The screenshot shows something different here. We'll want to follow the guidelines for integrations. Upload geospatial data with GDAL
sounded good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, that screenshot is out of date. Folded in @gchaps suggestions.
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Page load bundle
History
To update your PR or re-run it, just comment with: |
That'd be ideal scenario, but wondering if we could start with this. We've also have discussed a few times already for ingestion of shapefiles as well, to have an in-house solution. imho the purpose of this card is mainly to communicate to users that there are already tools out there that will ingest your static data into Elasticsearch. |
Summary
Part of #116653
Adds GDAL to the data integrations page, linking to the blog post https://www.elastic.co/blog/how-to-ingest-geospatial-data-into-elasticsearch-with-gdal
This also adds a
geo
category.Another PR will add a card for GeoJson. The latter one needs some more changes to the Maps-app, so preferring to keep that separate from here.