[Expressions] columns. Fixes Bugs caused by using name instead of ID.

[Kuznietsov]

Summary

Fixes bugs from this issue, related to columns expression.

New behavior:

Added support of IDs. If exclude or include contains ids and names, the expression first compares an id and then a name.

Expression:

esaggs index={indexPatternLoad id="90943e30-9a47-11e8-b64d-95841ca0b247"} 
  aggs={aggHistogram id="a" enabled=true schema="segment" field="bytes" maxBars=34 interval="auto" has_extended_bounds=false min_doc_count=false}
  aggs={aggSum id="b" enabled=true schema="metric" field="bytes"} metricsAtAllLevels=false partialRows=false
| head 1
| columns include="col-0-a" exclude="Sum of bytes"

Output of the head:

{
  "type": "datatable",
  "columns": [
    {
      "id": "col-0-a",
      "name": "bytes",
      "meta": {
        "type": "number",
        "field": "bytes",
        "index": "kibana_sample_data_logs",
        "params": {
          "id": "number"
        },
        "source": "esaggs",
      }
    },
    {
      "id": "col-1-b",
      "name": "Sum of bytes",
      "meta": {
        "type": "number",
        "field": "bytes",
        "index": "kibana_sample_data_logs",
        "params": {
          "id": "number"
        },
        "source": "esaggs",
      }
    }
  ],
  "rows": [
    {
      "col-0-a": 0,
      "col-1-b": 442647
    }
  ]
}

Result of the columns expression:

{
  "type": "datatable",
  "columns": [
    {
      "id": "col-0-a",
      "name": "bytes",
      "meta": {
        "type": "number",
        "field": "bytes",
        "index": "kibana_sample_data_logs",
        "params": {
          "id": "number"
        },
        "source": "esaggs",
      }
    },
  ],
  "rows": [
    {
      "col-0-a": 0,
    }
  ]
}

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)

[Kuznietsov]

@elasticmachine merge upstream

[crob611]

NIT: splitColumns is a more proper name

[Kuznietsov]

Done.

[crob611]

Looks good 👍

[Kuznietsov]

@elasticmachine merge upstream

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: d4dee2d
• Storybooks Preview

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
canvas	1015.0KB	1015.3KB	+300.0B

History

• 💚 Build #6549 succeeded 0d91684
• 💚 Build #6497 succeeded 31b9d88

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov