-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
propagate trace.id to http response log manually #118466
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
release_note:skip
Skip the PR/issue when compiling release notes
v8.1.0
labels
Nov 12, 2021
Pinging @elastic/kibana-core (Team:Core) |
mshustov
commented
Nov 22, 2021
x-pack/test/functional_execution_context/tests/log_correlation.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
TinaHeiligers
approved these changes
Nov 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a workaround for now and we'll need to keep checking on the apm issue status.
Core review only,
LGTM
lukeelmers
approved these changes
Nov 23, 2021
mshustov
added
auto-backport
Deprecated - use backport:version if exact versions are needed
backport:skip
This commit does not require backporting
and removed
auto-backport
Deprecated - use backport:version if exact versions are needed
labels
Nov 24, 2021
dmlemeshko
pushed a commit
that referenced
this pull request
Nov 29, 2021
* store traceId manually during hapi lifecycle * update functional test * REMOVE ME * REMOVE ME * REMOVE ME * arghhh * REMOVE ME * REMOVE ME * ARGH * cleanup * cleanup 2 * fix test * add ping check
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
* store traceId manually during hapi lifecycle * update functional test * REMOVE ME * REMOVE ME * REMOVE ME * arghhh * REMOVE ME * REMOVE ME * ARGH * cleanup * cleanup 2 * fix test * add ping check
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
v8.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #114476
http.server.response
logs are emitted when an APM transaction was finished, therefore it contains unrelevanttrace.id
value.APM agent is going to extend Hapi lifecycle instrumentation (tentatively in
v8.1.0
) elastic/apm-agent-nodejs#2353Until it's resolved in the upstream, we can work it around by storing
trace.id
for every incoming request.Kibana logs with this change (a short version for brevity) look like:
Note that the current implementation works for automatic instrumentation. If a plugin creates a custom transaction in a route handler manually, it must provide parents'
trace.id
to supportDistributed Tracing
.